From: Alex Tomas <alex@clusterfs.com>
To: Dmitry Monakhov <dmonakhov@sw.ru>
Cc: cmm@us.ibm.com, linux-ext4@vger.kernel.org
Subject: Re: delayed allocatiou result in Oops
Date: Tue, 19 Jun 2007 13:36:56 +0400 [thread overview]
Message-ID: <4677A3B8.3000007@clusterfs.com> (raw)
In-Reply-To: <20070619091628.GB20172@localhost.sw.ru>
Dmitry Monakhov wrote:
> But whole approach based on using PagePrivate bit and page->private
> ptr for special purposes is realy dengerous, and imho wrong,
> because avery fs-related code assume that page->private points to
> page_buffers. Especially this approach not work for blksize < pgsize.
> The best way to store/pass any block related info is buffer_head flags.
> This approach works for blksize < pgsize case too.
it's not dangerous as buffer_heads is optional facility
and any filesystem is free to use them or not. or even
use own mechanism like reiser4 does. this is why struct
page got private field instead of buffers (in 2.4).
buffer_heads have cost - 56 bytes/page (on 32bit arch)
+ cpu cycles to maintain them.
current delayed allocation isn't supposed to work with
bsize != PAGE_CACHE_SIZE. this will be resolved by the
upcoming patch, but bsize == PAGE_CACHE_SIZE is worthwhile
to optimize, I believe.
thanks, Alex
next prev parent reply other threads:[~2007-06-19 9:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-14 7:23 delayed allocatiou result in Oops Dmitriy Monakhov
2007-06-15 5:14 ` Alex Tomas
2007-06-15 23:16 ` Mingming Cao
2007-06-16 8:02 ` [PATCH] ext4:fix invariant checking in ext4_rebalance_reservation Dmitriy Monakhov
2007-06-18 21:09 ` Mingming Cao
2007-06-19 5:56 ` Dmitry Monakhov
2007-06-16 8:14 ` delayed allocatiou result in Oops Dmitriy Monakhov
2007-06-19 1:01 ` Mingming Cao
2007-06-19 7:11 ` Alex Tomas
2007-06-19 9:16 ` Dmitry Monakhov
2007-06-19 9:36 ` Alex Tomas [this message]
2007-06-19 21:50 ` Andreas Dilger
2007-06-19 16:23 ` Mingming Cao
2007-06-19 16:47 ` Aneesh Kumar K.V
2007-06-20 8:15 ` Alex Tomas
2007-06-20 23:46 ` Mingming Cao
2007-06-21 4:50 ` Dmitry Monakhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4677A3B8.3000007@clusterfs.com \
--to=alex@clusterfs.com \
--cc=cmm@us.ibm.com \
--cc=dmonakhov@sw.ru \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox