public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@infradead.org>
To: Andreas Dilger <aedilger@gmail.com>
Cc: Andreas Dilger <adilger@dilger.ca>,
	linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [e2fsprogs] initdir: Writing inode after the initial write?
Date: Tue, 04 Dec 2012 09:43:21 -0800	[thread overview]
Message-ID: <50BE3639.7090704@infradead.org> (raw)
In-Reply-To: <E9A4182B-CEE4-419A-AE6B-F7133766ABC3@gmail.com>



On 12/04/2012 02:59 AM, Andreas Dilger wrote:
> On 2012-12-03, at 12:46, Darren Hart <dvhart@infradead.org> wrote:
>>
>> It needs symlink as you said, but I can relatively easily migrate my
>> code for that in mke2fs to debugfs.
>>
>> Still needs permissions and such. Is that done with "modify_inode" ? If
>> so, how do I specify the new contents?
> 
> "modify_inode" is not a terribly easy use interface. Probably better to add something like "chmod" and "chown" for debugfs as well. 

I was thinking the same thing.

> 
>> I need to look into how to detect and support hard links.
> 
> I was wondering about that, and hoped you wouldn't need them.  Maybe just keep a list if any files with nlink > 1 as { inode, pathname } as you go, and any inode with mlink > 1 are looked first in the duplicate list and the duplicate inode is hard linked to the original inode. 
>
> Cheers, Andreas

Right, my thoughts as well. Thanks for the confirmation!

I don't know that I need them, but I imagine a complete solution will be
more acceptable than one that fits only our needs. So while we're in
there...

--
Darren

  reply	other threads:[~2012-12-04 17:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-01  2:13 [e2fsprogs] initdir: Writing inode after the initial write? Darren Hart
2012-12-01  4:23 ` Andreas Dilger
2012-12-01  5:08   ` Darren Hart
2012-12-01 19:31     ` Andreas Dilger
2012-12-03 19:46       ` Darren Hart
2012-12-04 10:45         ` Yongqiang Yang
2012-12-04 17:42           ` Darren Hart
2012-12-04 10:59         ` Andreas Dilger
2012-12-04 17:43           ` Darren Hart [this message]
2012-12-04 19:08             ` Theodore Ts'o
2012-12-04 19:40               ` Darren Hart
2012-12-04 20:00                 ` Theodore Ts'o
2012-12-04 20:10                   ` Darren Hart
2012-12-04 20:36                     ` Theodore Ts'o
2012-12-04 15:22         ` Theodore Ts'o
2012-12-04 17:46           ` Darren Hart
2012-12-04 19:24             ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50BE3639.7090704@infradead.org \
    --to=dvhart@infradead.org \
    --cc=adilger@dilger.ca \
    --cc=aedilger@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox