From: Marc Thomas <marc@dragonfly.plus.com>
To: linux-ext4@vger.kernel.org
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
"Theodore Ts'o" <tytso@mit.edu>
Subject: Re: [PATCH] e2fsck: fix sparse bmap to extent conversion
Date: Wed, 24 May 2017 12:30:58 +0100 [thread overview]
Message-ID: <982fc176-2a8d-1318-8eec-2524c6af1e00@dragonfly.plus.com> (raw)
In-Reply-To: <20170523190019.GF4510@birch.djwong.org>
Hi Darrick,
Thanks very much for the patch. I applied it to the git-master and built
e2fsprogs. The new "make check" test for "f_convert_bmap_sparse" passes,
and indeed my test-case script now passes.
However the test for "f_detect_junk" is failing for me:
---
$ cat f_detect_junk.failed
--- ../../tests/f_detect_junk/expect 2017-05-24 08:58:29.025273717 +0000
+++ f_detect_junk.log 2017-05-24 09:23:41.426168239 +0000
@@ -13,6 +13,7 @@
*** debugfs
test.img: Bad magic number in super-block while opening filesystem
+Checksum errors in superblock! Retrying...
*** tune2fs
../misc/tune2fs: Bad magic number in super-block while trying to open
test.img
*** mke2fs
---
I think the expect test maybe just needs updating.
I will now try the patched e2fsck on the full data-migration process I'm
doing and report back. This will take a few hours.
Kind Regards,
Marc
next prev parent reply other threads:[~2017-05-24 11:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 19:00 [PATCH] e2fsck: fix sparse bmap to extent conversion Darrick J. Wong
2017-05-24 11:30 ` Marc Thomas [this message]
2017-05-25 2:21 ` Theodore Ts'o
2017-05-25 13:11 ` Marc Thomas
2017-05-25 17:13 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=982fc176-2a8d-1318-8eec-2524c6af1e00@dragonfly.plus.com \
--to=marc@dragonfly.plus.com \
--cc=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox