From: Marc Thomas <marc@dragonfly.plus.com>
To: "Theodore Ts'o" <tytso@mit.edu>, linux-ext4@vger.kernel.org
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>
Subject: Re: [PATCH] e2fsck: fix sparse bmap to extent conversion
Date: Thu, 25 May 2017 14:11:52 +0100 [thread overview]
Message-ID: <e8704df9-dac3-d7c8-2907-b116d9a3f2e6@dragonfly.plus.com> (raw)
In-Reply-To: <20170525022135.tbzsiyd3cbvrdlto@thunk.org>
Thank you both for the rapid turn-around with this patch.
I can confirm it solves the original problem with the in-place ext3 to
ext4 conversion I'm doing.
As regards the f_detect_junk test, it seems a change in "debugfs" is
emitting an extra message "Checksum errors in superblock! Retrying..."
which is not present in the "expect" output.
It appears this was introduced in commit
https://git.kernel.org/pub/scm/fs/ext2/e2fsprogs.git/commit/?id=bf615bb0ccadeb1579463f94a2a4752e7ec53f57
Perhaps debugfs could print that message to stderr so it's not picked up?
I'm testing with the git master branch, but my git skills are weak so I
could well be doing something wrong!
Kind Regards,
Marc
next prev parent reply other threads:[~2017-05-25 13:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 19:00 [PATCH] e2fsck: fix sparse bmap to extent conversion Darrick J. Wong
2017-05-24 11:30 ` Marc Thomas
2017-05-25 2:21 ` Theodore Ts'o
2017-05-25 13:11 ` Marc Thomas [this message]
2017-05-25 17:13 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8704df9-dac3-d7c8-2907-b116d9a3f2e6@dragonfly.plus.com \
--to=marc@dragonfly.plus.com \
--cc=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox