* [patch] ext4: typo leads to small leak
@ 2009-03-27 10:36 Dan Carpenter
2009-03-27 14:13 ` Eric Sandeen
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2009-03-27 10:36 UTC (permalink / raw)
To: tytso, adilger; +Cc: linux-ext4
This was found by smatch (http://repo.or.cz/w/smatch.git/)
regards,
dan carpenter
Signed-off-by: Dan Carpenter <error27@gmail.com>
--- orig/fs/ext4/mballoc.c 2009-03-26 18:22:30.000000000 +0300
+++ devel/fs/ext4/mballoc.c 2009-03-26 18:22:56.000000000 +0300
@@ -2693,7 +2693,7 @@
i = (sb->s_blocksize_bits + 2) * sizeof(unsigned int);
sbi->s_mb_maxs = kmalloc(i, GFP_KERNEL);
if (sbi->s_mb_maxs == NULL) {
- kfree(sbi->s_mb_maxs);
+ kfree(sbi->s_mb_offsets);
return -ENOMEM;
}
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [patch] ext4: typo leads to small leak
2009-03-27 10:36 [patch] ext4: typo leads to small leak Dan Carpenter
@ 2009-03-27 14:13 ` Eric Sandeen
0 siblings, 0 replies; 2+ messages in thread
From: Eric Sandeen @ 2009-03-27 14:13 UTC (permalink / raw)
To: Dan Carpenter; +Cc: tytso, adilger, linux-ext4
Dan Carpenter wrote:
> This was found by smatch (http://repo.or.cz/w/smatch.git/)
>
> regards,
> dan carpenter
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Thanks! Maybe one for the stable trees.
> --- orig/fs/ext4/mballoc.c 2009-03-26 18:22:30.000000000 +0300
> +++ devel/fs/ext4/mballoc.c 2009-03-26 18:22:56.000000000 +0300
> @@ -2693,7 +2693,7 @@
> i = (sb->s_blocksize_bits + 2) * sizeof(unsigned int);
> sbi->s_mb_maxs = kmalloc(i, GFP_KERNEL);
> if (sbi->s_mb_maxs == NULL) {
> - kfree(sbi->s_mb_maxs);
> + kfree(sbi->s_mb_offsets);
> return -ENOMEM;
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-27 14:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-27 10:36 [patch] ext4: typo leads to small leak Dan Carpenter
2009-03-27 14:13 ` Eric Sandeen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox