From: "Darrick J. Wong" <djwong@kernel.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: Fix comment about the 64BIT feature
Date: Wed, 1 Mar 2023 18:58:47 -0800 [thread overview]
Message-ID: <ZAAQ5wxf16dBhvZl@magnolia> (raw)
In-Reply-To: <20230301133842.671821-1-tudor.ambarus@linaro.org>
On Wed, Mar 01, 2023 at 01:38:42PM +0000, Tudor Ambarus wrote:
> 64BIT is part of the incompatible feature set, update the comment
> accordingly.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
> fs/ext4/ext4.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index 140e1eb300d1..85c153e120b9 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -1387,7 +1387,7 @@ struct ext4_super_block {
> __le32 s_first_meta_bg; /* First metablock block group */
> __le32 s_mkfs_time; /* When the filesystem was created */
> __le32 s_jnl_blocks[17]; /* Backup of the journal inode */
> - /* 64bit support valid if EXT4_FEATURE_COMPAT_64BIT */
> + /* 64bit support valid if EXT4_FEATURE_INCOMPAT_64BIT */
Correct.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> /*150*/ __le32 s_blocks_count_hi; /* Blocks count */
> __le32 s_r_blocks_count_hi; /* Reserved blocks count */
> __le32 s_free_blocks_count_hi; /* Free blocks count */
> --
> 2.39.2.722.g9855ee24e9-goog
>
next prev parent reply other threads:[~2023-03-02 2:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 13:38 [PATCH] ext4: Fix comment about the 64BIT feature Tudor Ambarus
2023-03-02 2:58 ` Darrick J. Wong [this message]
2023-03-08 4:33 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAAQ5wxf16dBhvZl@magnolia \
--to=djwong@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox