* [PATCH] ext4: Fix comment about the 64BIT feature
@ 2023-03-01 13:38 Tudor Ambarus
2023-03-02 2:58 ` Darrick J. Wong
2023-03-08 4:33 ` Theodore Ts'o
0 siblings, 2 replies; 3+ messages in thread
From: Tudor Ambarus @ 2023-03-01 13:38 UTC (permalink / raw)
To: tytso; +Cc: adilger.kernel, linux-ext4, linux-kernel, Tudor Ambarus
64BIT is part of the incompatible feature set, update the comment
accordingly.
Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
---
fs/ext4/ext4.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 140e1eb300d1..85c153e120b9 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -1387,7 +1387,7 @@ struct ext4_super_block {
__le32 s_first_meta_bg; /* First metablock block group */
__le32 s_mkfs_time; /* When the filesystem was created */
__le32 s_jnl_blocks[17]; /* Backup of the journal inode */
- /* 64bit support valid if EXT4_FEATURE_COMPAT_64BIT */
+ /* 64bit support valid if EXT4_FEATURE_INCOMPAT_64BIT */
/*150*/ __le32 s_blocks_count_hi; /* Blocks count */
__le32 s_r_blocks_count_hi; /* Reserved blocks count */
__le32 s_free_blocks_count_hi; /* Free blocks count */
--
2.39.2.722.g9855ee24e9-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ext4: Fix comment about the 64BIT feature
2023-03-01 13:38 [PATCH] ext4: Fix comment about the 64BIT feature Tudor Ambarus
@ 2023-03-02 2:58 ` Darrick J. Wong
2023-03-08 4:33 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2023-03-02 2:58 UTC (permalink / raw)
To: Tudor Ambarus; +Cc: tytso, adilger.kernel, linux-ext4, linux-kernel
On Wed, Mar 01, 2023 at 01:38:42PM +0000, Tudor Ambarus wrote:
> 64BIT is part of the incompatible feature set, update the comment
> accordingly.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
> fs/ext4/ext4.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index 140e1eb300d1..85c153e120b9 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -1387,7 +1387,7 @@ struct ext4_super_block {
> __le32 s_first_meta_bg; /* First metablock block group */
> __le32 s_mkfs_time; /* When the filesystem was created */
> __le32 s_jnl_blocks[17]; /* Backup of the journal inode */
> - /* 64bit support valid if EXT4_FEATURE_COMPAT_64BIT */
> + /* 64bit support valid if EXT4_FEATURE_INCOMPAT_64BIT */
Correct.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> /*150*/ __le32 s_blocks_count_hi; /* Blocks count */
> __le32 s_r_blocks_count_hi; /* Reserved blocks count */
> __le32 s_free_blocks_count_hi; /* Free blocks count */
> --
> 2.39.2.722.g9855ee24e9-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ext4: Fix comment about the 64BIT feature
2023-03-01 13:38 [PATCH] ext4: Fix comment about the 64BIT feature Tudor Ambarus
2023-03-02 2:58 ` Darrick J. Wong
@ 2023-03-08 4:33 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2023-03-08 4:33 UTC (permalink / raw)
To: Tudor Ambarus; +Cc: Theodore Ts'o, linux-kernel, linux-ext4, adilger.kernel
On Wed, 1 Mar 2023 13:38:42 +0000, Tudor Ambarus wrote:
> 64BIT is part of the incompatible feature set, update the comment
> accordingly.
>
>
Applied, thanks!
[1/1] ext4: Fix comment about the 64BIT feature
commit: 7fc1f5c28ae4c615ccc5346f39a7bf4c4e0900ac
Best regards,
--
Theodore Ts'o <tytso@mit.edu>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-08 4:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-01 13:38 [PATCH] ext4: Fix comment about the 64BIT feature Tudor Ambarus
2023-03-02 2:58 ` Darrick J. Wong
2023-03-08 4:33 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox