[PATCH] ext4: remove unnecessary duplicate check in ext4_map_blocks()

[PATCH] ext4: remove unnecessary duplicate check in ext4_map_blocks()

[Dan Carpenter]

The previous lines ensure that EXT4_GET_BLOCKS_QUERY_LAST_IN_LEAF is
set so remove this duplicate check.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 fs/ext4/inode.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index be9a4cba35fd..014021019b22 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -757,8 +757,7 @@ int ext4_map_blocks(handle_t *handle, struct inode *inode,
 				orig_mlen == map->m_len)
 			goto found;
 
-		if (flags & EXT4_GET_BLOCKS_QUERY_LAST_IN_LEAF)
-			map->m_len = orig_mlen;
+		map->m_len = orig_mlen;
 	}
 	/*
 	 * In the query cache no-wait mode, nothing we can do more if we
-- 
2.47.2

Re: [PATCH] ext4: remove unnecessary duplicate check in ext4_map_blocks()

[Ritesh Harjani]

Dan Carpenter <dan.carpenter@linaro.org> writes:

> The previous lines ensure that EXT4_GET_BLOCKS_QUERY_LAST_IN_LEAF is
> set so remove this duplicate check.
>

Earlier, I knew it was a redundant check, but I went ahead with it
anyway; and later, I might have missed removing it. I agree that we
don’t really need this extra check.

So, the patch looks good to me. Thanks for taking care of it!

Please feel free to add:
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>


> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>  fs/ext4/inode.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index be9a4cba35fd..014021019b22 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -757,8 +757,7 @@ int ext4_map_blocks(handle_t *handle, struct inode *inode,
>  				orig_mlen == map->m_len)
>  			goto found;
>  
> -		if (flags & EXT4_GET_BLOCKS_QUERY_LAST_IN_LEAF)
> -			map->m_len = orig_mlen;
> +		map->m_len = orig_mlen;
>  	}
>  	/*
>  	 * In the query cache no-wait mode, nothing we can do more if we
> -- 
> 2.47.2