* [bug report] ext4: refactor zeroout path and handle all cases [not found] <caa37f28-a2e8-4e0a-a9ce-a365ce805e4b@stanley.mountain> @ 2026-02-06 13:40 ` Dan Carpenter 2026-02-06 15:44 ` Ojaswin Mujoo 0 siblings, 1 reply; 2+ messages in thread From: Dan Carpenter @ 2026-02-06 13:40 UTC (permalink / raw) To: Ojaswin Mujoo; +Cc: linux-ext4, linux-kernel [ Smatch checking is paused while we raise funding. #SadFace https://lore.kernel.org/all/aTaiGSbWZ9DJaGo7@stanley.mountain/ -dan ] Hello Ojaswin Mujoo, Commit a985e07c2645 ("ext4: refactor zeroout path and handle all cases") from Jan 23, 2026 (linux-next), leads to the following Smatch static checker warning: fs/ext4/extents.c:3369 ext4_split_extent_zeroout() warn: duplicate zero check 'err' (previous on line 3363) fs/ext4/extents.c 3361 3362 err = ext4_ext_get_access(handle, inode, path + depth); 3363 if (err) 3364 return err; 3365 3366 ext4_ext_mark_initialized(ex); 3367 3368 ext4_ext_dirty(handle, inode, path + depth); Presumably "err = ext4_ext_dirty()". --> 3369 if (err) 3370 return err; 3371 3372 return 0; 3373 } regards, dan carpenter ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [bug report] ext4: refactor zeroout path and handle all cases 2026-02-06 13:40 ` [bug report] ext4: refactor zeroout path and handle all cases Dan Carpenter @ 2026-02-06 15:44 ` Ojaswin Mujoo 0 siblings, 0 replies; 2+ messages in thread From: Ojaswin Mujoo @ 2026-02-06 15:44 UTC (permalink / raw) To: Dan Carpenter; +Cc: linux-ext4, linux-kernel On Fri, Feb 06, 2026 at 04:40:38PM +0300, Dan Carpenter wrote: > [ Smatch checking is paused while we raise funding. #SadFace > https://lore.kernel.org/all/aTaiGSbWZ9DJaGo7@stanley.mountain/ -dan ] > > Hello Ojaswin Mujoo, > > Commit a985e07c2645 ("ext4: refactor zeroout path and handle all > cases") from Jan 23, 2026 (linux-next), leads to the following Smatch > static checker warning: > > fs/ext4/extents.c:3369 ext4_split_extent_zeroout() > warn: duplicate zero check 'err' (previous on line 3363) > > fs/ext4/extents.c > 3361 > 3362 err = ext4_ext_get_access(handle, inode, path + depth); > 3363 if (err) > 3364 return err; > 3365 > 3366 ext4_ext_mark_initialized(ex); > 3367 > 3368 ext4_ext_dirty(handle, inode, path + depth); > > Presumably "err = ext4_ext_dirty()". > > --> 3369 if (err) > 3370 return err; > 3371 > 3372 return 0; > 3373 } > > regards, > dan carpenter Hi dan, Thanks for the report, I'll send a patch for this. Many thanks for all the work you do and hope you are able to work out a way to carry the smatch project forward! Regards, ojaswin ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-06 15:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <caa37f28-a2e8-4e0a-a9ce-a365ce805e4b@stanley.mountain>
2026-02-06 13:40 ` [bug report] ext4: refactor zeroout path and handle all cases Dan Carpenter
2026-02-06 15:44 ` Ojaswin Mujoo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox