From: Christoph Hellwig <hch@infradead.org>
To: Anand Jain <asj@kernel.org>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, amir73il@gmail.com,
zlang@redhat.com, hch@infradead.org
Subject: Re: [PATCH v5 04/10] fstests: verify fanotify isolation on cloned filesystems
Date: Mon, 25 May 2026 00:11:52 -0700 [thread overview]
Message-ID: <ahP2OOXmwsM87j9D@infradead.org> (raw)
In-Reply-To: <bfc0c92a33bf5a129dad4c3e4c76973e7a6cec74.1779367627.git.asj@kernel.org>
> +export FSNOTIFYWAIT_PROG="$(type -P fsnotifywait)"
Same comment about adding new common bits outside of test cases applies,
but why use both inotify and fsnotify?
> +[[ "$fsid1" == "$fsid2" ]] && \
> + _notrun "Require clone filesystem with unique f_fsid"
Please add a comment why this happens. I also have to say I find
the if syntax easier to follow then && with a line continuation.
next prev parent reply other threads:[~2026-05-25 7:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 12:54 [PATCH v5 0/10] fstests: add test coverage for cloned filesystem ids Anand Jain
2026-05-21 12:54 ` [PATCH v5 01/10] fstests: add _loop_image_create_clone() helper Anand Jain
2026-05-25 7:07 ` Christoph Hellwig
2026-05-21 12:54 ` [PATCH v5 02/10] fstests: add _clone_mount_option() helper Anand Jain
2026-05-25 7:07 ` Christoph Hellwig
2026-05-21 12:54 ` [PATCH v5 03/10] fstests: add test for inotify isolation on cloned devices Anand Jain
2026-05-25 7:09 ` Christoph Hellwig
2026-05-25 8:35 ` Anand Jain
2026-05-21 12:54 ` [PATCH v5 04/10] fstests: verify fanotify isolation on cloned filesystems Anand Jain
2026-05-25 7:11 ` Christoph Hellwig [this message]
2026-05-25 8:20 ` Anand Jain
2026-05-21 12:54 ` [PATCH v5 05/10] fstests: verify f_fsid for " Anand Jain
2026-05-25 7:13 ` Christoph Hellwig
2026-05-21 12:54 ` [PATCH v5 06/10] fstests: verify libblkid resolution of duplicate UUIDs Anand Jain
2026-05-21 12:54 ` [PATCH v5 07/10] fstests: verify IMA isolation on cloned filesystems Anand Jain
2026-05-21 12:54 ` [PATCH v5 08/10] fstests: verify exportfs file handles " Anand Jain
2026-05-21 12:54 ` [PATCH v5 09/10] fstests: add pre_clone_tune_uuid() healper Anand Jain
2026-05-21 13:10 ` Anand Jain
2026-05-25 7:14 ` Christoph Hellwig
2026-05-25 7:31 ` Anand Jain
2026-05-25 7:48 ` Christoph Hellwig
2026-05-21 12:55 ` [PATCH v5 10/10] fstests: test UUID consistency for clones with metadata_uuid Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahP2OOXmwsM87j9D@infradead.org \
--to=hch@infradead.org \
--cc=amir73il@gmail.com \
--cc=asj@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox