From: "Lukáš Czerner" <lczerner@redhat.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org, jack@suse.cz, stable@vger.kernel.org
Subject: Re: [PATCH] ext4: Fix punch hole on files with indirect mapping
Date: Thu, 26 Jun 2014 18:30:22 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.00.1406261829190.2172@localhost.localdomain> (raw)
In-Reply-To: <alpine.LFD.2.00.1406261827080.2172@localhost.localdomain>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1757 bytes --]
On Thu, 26 Jun 2014, Lukáš Czerner wrote:
> Date: Thu, 26 Jun 2014 18:28:57 +0200 (CEST)
> From: Lukáš Czerner <lczerner@redhat.com>
> To: Theodore Ts'o <tytso@mit.edu>
> Cc: linux-ext4@vger.kernel.org, jack@suse.cz, stable@vger.kernel.org
> Subject: Re: [PATCH] ext4: Fix punch hole on files with indirect mapping
>
> On Thu, 26 Jun 2014, Theodore Ts'o wrote:
>
> > Date: Thu, 26 Jun 2014 12:24:50 -0400
> > From: Theodore Ts'o <tytso@mit.edu>
> > To: Lukas Czerner <lczerner@redhat.com>
> > Cc: linux-ext4@vger.kernel.org, jack@suse.cz, stable@vger.kernel.org
> > Subject: Re: [PATCH] ext4: Fix punch hole on files with indirect mapping
> >
> > I like the performance improvement of your patch, but I'm concerned
> > that it might be a bit too complicated to push outside of the merge
> > window.
> >
> > So what I propose doing is this. We'll take Jan's patches and after
> > testing, we'll push it to Linus. Then for the the 3.17 merge window,
> > after we've had more opportunity for testing and for other folks to
> > review your changes, we can queue this patch (or its successor).
> >
> > Does that seem like a good path forward?
> >
> > - Ted
>
> It does. But this is not exactly a critical bug and it has been
> there since the introduction of punch hole for indirect file. But I
> guess it's better to fix it sooner rather than later, so I am fine
> with this.
It's also better to send Jan's fix to stable trees and let my fix be
just in the Linus tree since it's quite big for stable I think.
-Lukas
>
> Thanks!
> -Lukas
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-06-26 16:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 15:37 [PATCH] ext4: Fix punch hole on files with indirect mapping Lukas Czerner
2014-06-19 17:45 ` Jan Kara
2014-06-20 11:28 ` Lukáš Czerner
2014-06-23 9:40 ` Lukáš Czerner
2014-06-26 16:24 ` Theodore Ts'o
2014-06-26 16:28 ` Lukáš Czerner
2014-06-26 16:30 ` Lukáš Czerner [this message]
2014-06-27 1:33 ` Theodore Ts'o
2014-06-27 10:58 ` Lukáš Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1406261829190.2172@localhost.localdomain \
--to=lczerner@redhat.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox