Re: [PATCH] ext4: Fix punch hole on files with indirect mapping

["Lukáš Czerner" <lczerner@redhat.com>]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1047 bytes --]

On Thu, 26 Jun 2014, Theodore Ts'o wrote:

> Date: Thu, 26 Jun 2014 21:33:29 -0400
> From: Theodore Ts'o <tytso@mit.edu>
> To: Lukáš Czerner <lczerner@redhat.com>
> Cc: linux-ext4@vger.kernel.org, jack@suse.cz, stable@vger.kernel.org
> Subject: Re: [PATCH] ext4: Fix punch hole on files with indirect mapping
> 
> On Thu, Jun 26, 2014 at 06:28:57PM +0200, Lukáš Czerner wrote:
> > 
> > It does. But this is not exactly a critical bug and it has been
> > there since the introduction of punch hole for indirect file. But I
> > guess it's better to fix it sooner rather than later, so I am fine
> > with this.
> 
> One of the reasons why I want to get this fixed sooner rather than
> later is that even when testing a stock ext4 file system, fsstress can
> potentially create indirect mapped files that could then get punched.
> So I wonder if bug might be responsible for some of the very random
> failures that I've been seeing in my testing...
> 
> 					- Ted

Fair enough, we can wait with my patch for the next merge window.

Thanks!
-Lukas