From: "Theodore Tso" <tytso@mit.edu>
To: Matthias Goergens <matthias.goergens@gmail.com>
Cc: linux-ext4@vger.kernel.org, jack@suse.cz,
sashiko-reviews@lists.linux.dev
Subject: Re: [PATCH] ext4: compensate ea_inode refs and free block on new xattr block write error\
Date: Mon, 17 Aug 2026 11:29:18 -0400 [thread overview]
Message-ID: <aoMe0uuQnGovxMSH@mit.edu> (raw)
In-Reply-To: <20260817114905.2708356-1-matthias.goergens@gmail.com>
On Mon, Aug 17, 2026 at 07:49:05PM -0500, Matthias Goergens wrote:
> Sashiko's reviews on these threads have been genuinely useful — the
> ea_inode refcount leak that this patch follows up on was its find. This
> one, though, is a false positive: mb_cache_entry_delete_or_get() and
> mb_cache_entry_wait_unused() have been defined in fs/mbcache.c and
> declared in include/linux/mbcache.h since commit 3dc96bba65f5 ("mbcache:
> add functions to delete entry if unused", 2022)
Yeah, I had noticed this and filed a bug against Sashiko.
https://github.com/sashiko-dev/sashiko/issues/439
(Filed before github went down.)
- Ted
prev parent reply other threads:[~2026-08-17 15:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 4:45 [PATCH 1/1] ext4: drop extra ea_inode ref in cached-block reuse path Matthias Goergens
2026-08-12 5:05 ` sashiko-bot
2026-08-14 6:50 ` [PATCH v2] " Matthias Goergens
2026-08-14 7:04 ` sashiko-bot
2026-08-17 9:54 ` [PATCH] ext4: compensate ea_inode refs and free block on new xattr block write error Matthias Goergens
2026-08-17 10:07 ` sashiko-bot
2026-08-17 11:49 ` Matthias Goergens
2026-08-17 15:29 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoMe0uuQnGovxMSH@mit.edu \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=matthias.goergens@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox