[tytso-ext4:dev 21/41] fs/ext4/inode.c:4002:24: sparse: sparse: symbol 'ext4_iomap_buffered_read_ops' was not declared. Should it be static?

[tytso-ext4:dev 21/41] fs/ext4/inode.c:4002:24: sparse: sparse: symbol 'ext4_iomap_buffered_read_ops' was not declared. Should it be static?

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
head:   35aefefd7aba0801bab635b11943f932626be3b2
commit: e933fd1b6cd5322563d5caf283dabd9cd09bcef8 [21/41] ext4: implement buffered read path using iomap
config: arm-randconfig-r2308-20261008 (https://download.01.org/0day-ci/archive/20261008/202610082225.lcsAyIiF-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 16.1.0
sparse: v0.6.5-rc1
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261008/202610082225.lcsAyIiF-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610082225.lcsAyIiF-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> fs/ext4/inode.c:4002:24: sparse: sparse: symbol 'ext4_iomap_buffered_read_ops' was not declared. Should it be static?

vim +/ext4_iomap_buffered_read_ops +4002 fs/ext4/inode.c

  3998	
  3999	static DEFINE_IOMAP_ITER_NEXT(ext4_iomap_buffered_read_next,
  4000				      ext4_iomap_buffered_read_begin);
  4001	
> 4002	const struct iomap_ops ext4_iomap_buffered_read_ops = {
  4003		.iomap_next = ext4_iomap_buffered_read_next,
  4004	};
  4005	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [tytso-ext4:dev 21/41] fs/ext4/inode.c:4002:24: sparse: sparse: symbol 'ext4_iomap_buffered_read_ops' was not declared. Should it be static?

[Zhang Yi]

On 10/9/2026 4:18 AM, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
> head:   35aefefd7aba0801bab635b11943f932626be3b2
> commit: e933fd1b6cd5322563d5caf283dabd9cd09bcef8 [21/41] ext4: implement buffered read path using iomap
> config: arm-randconfig-r2308-20261008 (https://download.01.org/0day-ci/archive/20261008/202610082225.lcsAyIiF-lkp@intel.com/config)
> compiler: arm-linux-gnueabi-gcc (GCC) 16.1.0
> sparse: v0.6.5-rc1
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261008/202610082225.lcsAyIiF-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202610082225.lcsAyIiF-lkp@intel.com/
> 
> sparse warnings: (new ones prefixed by >>)
>>> fs/ext4/inode.c:4002:24: sparse: sparse: symbol 'ext4_iomap_buffered_read_ops' was not declared. Should it be static?
> 
> vim +/ext4_iomap_buffered_read_ops +4002 fs/ext4/inode.c
> 
>    3998	
>    3999	static DEFINE_IOMAP_ITER_NEXT(ext4_iomap_buffered_read_next,
>    4000				      ext4_iomap_buffered_read_begin);
>    4001	
>> 4002	const struct iomap_ops ext4_iomap_buffered_read_ops = {
>    4003		.iomap_next = ext4_iomap_buffered_read_next,
>    4004	};
>    4005	
> 

Thanks for the report. ext4_iomap_buffered_read_ops should indeed be
marked static, and I've already fixed this in my local v7[1]. v7 also
includes fixes for some corner case issues reported by Sashiko on v6 as
well as some small optimizations, and I expect to send it out today or
tomorrow once testing is done.

Hi Ted, would it be okay to replace the current version with my v7 on
ext4 dev branch after I send it out?

[1] https://github.com/zhangyi089/linux/commits/ext4_buffered_iomap_v7/

Thanks,
Yi.

> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki

Re: [tytso-ext4:dev 21/41] fs/ext4/inode.c:4002:24: sparse: sparse: symbol 'ext4_iomap_buffered_read_ops' was not declared. Should it be static?

[Theodore Tso]

On Fri, Oct 09, 2026 at 10:55:18AM -0500, Zhang Yi wrote:
> Hi Ted, would it be okay to replace the current version with my v7 on
> ext4 dev branch after I send it out?

Sure, no problem.  I took a quick look and it looks like there were
one or two new Sashiko issues?  I'll give time for folks to take a
look, and I'll rerun my tests on the v7 patch series, so I might not
pull it in right away.

						- Ted

Re: [tytso-ext4:dev 21/41] fs/ext4/inode.c:4002:24: sparse: sparse: symbol 'ext4_iomap_buffered_read_ops' was not declared. Should it be static?

[Zhang Yi]

On 10/10/2026 3:03 AM, Theodore Tso wrote:
> On Fri, Oct 09, 2026 at 10:55:18AM -0500, Zhang Yi wrote:
>> Hi Ted, would it be okay to replace the current version with my v7 on
>> ext4 dev branch after I send it out?
> 
> Sure, no problem.  I took a quick look and it looks like there were
> one or two new Sashiko issues?  I'll give time for folks to take a
> look, and I'll rerun my tests on the v7 patch series, so I might not
> pull it in right away.
> 
> 						- Ted

Hi Ted,

I've gone through the Sashiko and syzbot reports one by one, and apart
from some pre-existing issues and false positives, no new regressions
were found. However, there are currently two nits in the code that need
adjustment:

  - The WARN_ON_ONCE() check in patch 8 is too heavy and is better
    removed, since it seems to expose some corner pre-existing issues in
    the buffer_head path and causes syzbot noise[1]. This syzbot report
    doesn't belong to the current series and may need to be addressed
    separately.

  - The tracepoint in patch 19 may print an uninitialized map->m_pblk
    during delalloc writes, so it needs to be initialized. I'd prefer to
    initialize it separately in ext4_da_map_blocks().

Since you've already started testing this series, and these two nits
aren't critical I think, I can send fix patches to address them
separately, or let me know if you'd prefer that I send a v8 instead.

[1] 
https://lore.kernel.org/linux-ext4/34423908-aceb-4c57-9502-7da10b12e4a4@huaweicloud.com/

Cheers,
Yi.