From: "Mulyadi Santosa" <mulyadi.santosa@gmail.com>
To: "Manish Katiyar" <mkatiyar@gmail.com>
Cc: "Kernel Newbies" <kernelnewbies@nl.linux.org>,
linux-ext4@vger.kernel.org
Subject: Re: Using tgid instead of pid in ext3_find_near()
Date: Tue, 29 Apr 2008 07:57:05 +0700 [thread overview]
Message-ID: <f284c33d0804281757x7433465h8828eb90a8d762ef@mail.gmail.com> (raw)
In-Reply-To: <ea11fea30804281207u5fe9e96bod992dc2bb2d3fc79@mail.gmail.com>
Ehmmm....
On Tue, Apr 29, 2008 at 2:07 AM, Manish Katiyar <mkatiyar@gmail.com> wrote:
> Hi,
>
> In the function ext*_find_near() we are using pid to have the locality
> of the blocks for the files which have same functionality. Shouldn't
> we be using "current->tgid" here instead ??
>
> 410 static ext3_fsblk_t ext3_find_near(struct inode *inode, Indirect *ind)
> 411 {
> .........
> ........
> 433 colour = (current->pid % 16) *
> 434 (EXT3_BLOCKS_PER_GROUP(inode->i_sb) / 16);
> ........
Because each threads even on same thread group doesn't need to share
open file descriptors?
regards,
Mulyadi.
next prev parent reply other threads:[~2008-04-29 0:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 19:07 Using tgid instead of pid in ext3_find_near() Manish Katiyar
2008-04-29 0:57 ` Mulyadi Santosa [this message]
2008-04-29 4:23 ` Manish Katiyar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f284c33d0804281757x7433465h8828eb90a8d762ef@mail.gmail.com \
--to=mulyadi.santosa@gmail.com \
--cc=kernelnewbies@nl.linux.org \
--cc=linux-ext4@vger.kernel.org \
--cc=mkatiyar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox