Re: [PATCH 12/27] ext4: add KUnit tests for fs/ext4/balloc.c

[sashiko-bot@kernel.org]

> Add the ext4_balloc_test KUnit test suite in fs/ext4/balloc-test.c (29
> test cases, 43 subtests total) to comprehensively exercise block bitmap
> management, group descriptor and overhead calculations, cluster pool
> reservation, allocation retry policy, metadata block allocation, and
> goal block selection in fs/ext4/balloc.c using an in-memory VFS
> superblock, mock block device, and deterministic block pool without
> requiring a mounted block device:
> 
> - Block-to-group and cluster-offset mapping (ext4_get_group_number and
>   ext4_get_group_no_and_offset) across 1K and 4K block sizes, standard
>   shift-based vs. non-standard do_div group geometries, bigalloc
>   multi-block clusters, s_first_data_block offsets, >32-bit physical
>   block numbers, and optional NULL output pointers.
> - Backup superblock placement (ext4_bg_has_super) across dense
>   filesystems, sparse_super powers of 3, 5, and 7, and sparse_super2
> [ ... ]
> through ext4_sb_getblk() so KUnit tests can intercept buffer-cache
> lookups via its existing static stub hook, and export the remaining
> non-static balloc.c entry points with EXPORT_SYMBOL_FOR_EXT4_TEST.
> 
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112040638.1576836-1-tytso@mit.edu?part=12