Re: [PATCH 13/27] ext4: add KUnit tests for fs/ext4/orphan.c

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] ext4: unexported ext4_superblock_csum_set() breaks modular
  KUnit build
--

commit 7b2d7b8d20233b110a9621f769fa6154acdc1c4b
Author: Theodore Ts'o <tytso@mit.edu>

ext4: add KUnit tests for fs/ext4/orphan.c

This commit adds a KUnit test suite for orphan inode tracking, orphan file
management, and mount-time orphan recovery in fs/ext4/orphan-test.c, along
with a static stub redirect in ext4_truncate() and test symbol exports.

> diff --git a/fs/ext4/orphan-test.c b/fs/ext4/orphan-test.c
> new file mode 100644
> index 0000000000000..f93057df1d31d
> --- /dev/null
> +++ b/fs/ext4/orphan-test.c
[ ... ]
> +static int orphan_test_init(struct kunit *test)
> +{
[ ... ]
> +	/* Keep sb_bh unmapped so ext4_commit_super() skips bh_submit I/O */
> +	ctx->sb_bh.b_data = (char *)&ctx->es;
> +	ctx->sb_bh.b_size = sizeof(ctx->es);
> +	ctx->sb_bh.b_bdev = &ctx->bdev;
> +	atomic_set(&ctx->sb_bh.b_count, 1);
> +	set_buffer_uptodate(&ctx->sb_bh);
> +	sbi->s_sbh = &ctx->sb_bh;
> +	ext4_superblock_csum_set(sb);

[Severity: Medium]
Does calling ext4_superblock_csum_set() here break the build when
CONFIG_EXT4_KUNIT_TESTS=m?  orphan-test.o is linked into ext4-test.ko while
ext4_superblock_csum_set() in fs/ext4/super.c is not exported with
EXPORT_SYMBOL_FOR_EXT4_TEST(ext4_superblock_csum_set) until a later commit
in the series, commit "ext4: add KUnit tests for fs/ext4/super.c", causing
modpost to fail with an undefined symbol error and breaking bisection.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112040638.1576836-1-tytso@mit.edu?part=13