* [PATCH] ext4: check RLIMIT_FSIZE in insert range
@ 2026-11-16 18:58 Hungyu Lin
2026-11-16 19:02 ` sashiko-bot
0 siblings, 1 reply; 2+ messages in thread
From: Hungyu Lin @ 2026-11-16 18:58 UTC (permalink / raw)
To: tytso
Cc: adilger.kernel, libaokun, jack, ojaswin, ritesh.list, yi.zhang,
namjae.jeon, a.sangwan, linux-ext4, linux-kernel, dennylin0707
ext4_insert_range() grows the file by len bytes but only checks the new
size against s_maxbytes. FALLOC_FL_INSERT_RANGE can therefore make a
file larger than RLIMIT_FSIZE allows, while ftruncate() and the
fallocate() modes that extend a file fail with -EFBIG and SIGXFSZ. xfs,
f2fs and ntfs3 already refuse to insert a range past the limit.
Fix this by validating the new size with inode_newsize_ok(), as
ext4_do_fallocate() and ext4_zero_range() do.
Fixes: 331573febb6a ("ext4: Add support FALLOC_FL_INSERT_RANGE for fallocate")
Cc: stable@vger.kernel.org
Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
fs/ext4/extents.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index ad0d80e33f60..94b9e091ef5f 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -5803,6 +5803,9 @@ static int ext4_insert_range(struct file *file, loff_t offset, loff_t len)
/* Check whether the maximum file size would be exceeded */
if (len > inode->i_sb->s_maxbytes - inode->i_size)
return -EFBIG;
+ ret = inode_newsize_ok(inode, inode->i_size + len);
+ if (ret)
+ return ret;
/*
* Persist the pending zeroed EOF block to ensure i_disksize
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4: check RLIMIT_FSIZE in insert range
2026-11-16 18:58 [PATCH] ext4: check RLIMIT_FSIZE in insert range Hungyu Lin
@ 2026-11-16 19:02 ` sashiko-bot
0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-11-16 19:02 UTC (permalink / raw)
To: Hungyu Lin; +Cc: linux-ext4, tytso
> ext4_insert_range() grows the file by len bytes but only checks the new
> size against s_maxbytes. FALLOC_FL_INSERT_RANGE can therefore make a
> file larger than RLIMIT_FSIZE allows, while ftruncate() and the
> fallocate() modes that extend a file fail with -EFBIG and SIGXFSZ. xfs,
> f2fs and ntfs3 already refuse to insert a range past the limit.
>
> Fix this by validating the new size with inode_newsize_ok(), as
> ext4_do_fallocate() and ext4_zero_range() do.
>
> Fixes: 331573febb6a ("ext4: Add support FALLOC_FL_INSERT_RANGE for fallocate")
> Cc: stable@vger.kernel.org
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116185810.82581-1-dennylin0707@gmail.com?part=1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-16 19:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-16 18:58 [PATCH] ext4: check RLIMIT_FSIZE in insert range Hungyu Lin
2026-11-16 19:02 ` sashiko-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox