[f2fs-dev] [PATCH] f2fs: Remove unused curseg_segno() and curseg_alloc_type()

[f2fs-dev] [PATCH] f2fs: Remove unused curseg_segno() and curseg_alloc_type()

[Zhan Xusheng]

The only callers of curseg_segno() and curseg_alloc_type() were removed by
commit 5a4fed7cd97a ("f2fs: simplify do_checkpoint"); both helpers have
been unused since then.

Being static inline functions they do not trigger -Wunused-function, so
the dead code has gone unnoticed.  Remove them.  No functional change.

Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
---
 fs/f2fs/segment.h | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h
index b0c06b3580b4..33a2257da1e6 100644
--- a/fs/f2fs/segment.h
+++ b/fs/f2fs/segment.h
@@ -796,20 +796,6 @@ F2FS_IPU_POLICY(F2FS_IPU_ASYNC);
 F2FS_IPU_POLICY(F2FS_IPU_NOCACHE);
 F2FS_IPU_POLICY(F2FS_IPU_HONOR_OPU_WRITE);
 
-static inline unsigned int curseg_segno(struct f2fs_sb_info *sbi,
-		int type)
-{
-	struct curseg_info *curseg = CURSEG_I(sbi, type);
-	return curseg->segno;
-}
-
-static inline unsigned char curseg_alloc_type(struct f2fs_sb_info *sbi,
-		int type)
-{
-	struct curseg_info *curseg = CURSEG_I(sbi, type);
-	return curseg->alloc_type;
-}
-
 static inline bool valid_main_segno(struct f2fs_sb_info *sbi,
 		unsigned int segno)
 {
-- 
2.43.0



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH] f2fs: Remove unused curseg_segno() and curseg_alloc_type()

[Chao Yu via Linux-f2fs-devel]

On 6/26/26 11:07, Zhan Xusheng wrote:
> The only callers of curseg_segno() and curseg_alloc_type() were removed by
> commit 5a4fed7cd97a ("f2fs: simplify do_checkpoint"); both helpers have
> been unused since then.
> 
> Being static inline functions they do not trigger -Wunused-function, so
> the dead code has gone unnoticed.  Remove them.  No functional change.
> 
> Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel