* [f2fs-dev] [PATCH] dump.f2fs: macOS does not support lsetxattr
@ 2026-03-13 13:09 LuK1337
2026-04-25 9:39 ` Łukasz Patron
2026-04-27 7:33 ` Chao Yu via Linux-f2fs-devel
0 siblings, 2 replies; 3+ messages in thread
From: LuK1337 @ 2026-03-13 13:09 UTC (permalink / raw)
To: linux-f2fs-devel; +Cc: Łukasz Patron, jaegeuk
From: Łukasz Patron <priv.luk@gmail.com>
Fixes: a66d49fd2678 ("dump.f2fs: Dump symlinks as symlinks")
Signed-off-by: Łukasz Patron <priv.luk@gmail.com>
---
fsck/dump.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fsck/dump.c b/fsck/dump.c
index f5c95de..7d20275 100644
--- a/fsck/dump.c
+++ b/fsck/dump.c
@@ -464,9 +464,9 @@ static void dump_xattr(struct f2fs_sb_info *sbi, struct f2fs_node *node_blk, int
le16_to_cpu(ent->e_value_size), 0,
XATTR_CREATE);
} if (S_ISLNK(type) && c.preserve_symlinks) {
- ret = lsetxattr(c.dump_symlink, xattr_name, value,
+ ret = setxattr(c.dump_symlink, xattr_name, value,
le16_to_cpu(ent->e_value_size), 0,
- XATTR_CREATE);
+ XATTR_CREATE | XATTR_NOFOLLOW);
} else {
ret = fsetxattr(c.dump_fd, xattr_name, value,
le16_to_cpu(ent->e_value_size), 0,
--
2.53.0
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [f2fs-dev] [PATCH] dump.f2fs: macOS does not support lsetxattr
2026-03-13 13:09 [f2fs-dev] [PATCH] dump.f2fs: macOS does not support lsetxattr LuK1337
@ 2026-04-25 9:39 ` Łukasz Patron
2026-04-27 7:33 ` Chao Yu via Linux-f2fs-devel
1 sibling, 0 replies; 3+ messages in thread
From: Łukasz Patron @ 2026-04-25 9:39 UTC (permalink / raw)
To: linux-f2fs-devel; +Cc: jaegeuk
ping
On Fri, Mar 13, 2026 at 2:09 PM LuK1337 <priv.luk@gmail.com> wrote:
>
> From: Łukasz Patron <priv.luk@gmail.com>
>
> Fixes: a66d49fd2678 ("dump.f2fs: Dump symlinks as symlinks")
> Signed-off-by: Łukasz Patron <priv.luk@gmail.com>
> ---
> fsck/dump.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fsck/dump.c b/fsck/dump.c
> index f5c95de..7d20275 100644
> --- a/fsck/dump.c
> +++ b/fsck/dump.c
> @@ -464,9 +464,9 @@ static void dump_xattr(struct f2fs_sb_info *sbi, struct f2fs_node *node_blk, int
> le16_to_cpu(ent->e_value_size), 0,
> XATTR_CREATE);
> } if (S_ISLNK(type) && c.preserve_symlinks) {
> - ret = lsetxattr(c.dump_symlink, xattr_name, value,
> + ret = setxattr(c.dump_symlink, xattr_name, value,
> le16_to_cpu(ent->e_value_size), 0,
> - XATTR_CREATE);
> + XATTR_CREATE | XATTR_NOFOLLOW);
> } else {
> ret = fsetxattr(c.dump_fd, xattr_name, value,
> le16_to_cpu(ent->e_value_size), 0,
> --
> 2.53.0
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [f2fs-dev] [PATCH] dump.f2fs: macOS does not support lsetxattr
2026-03-13 13:09 [f2fs-dev] [PATCH] dump.f2fs: macOS does not support lsetxattr LuK1337
2026-04-25 9:39 ` Łukasz Patron
@ 2026-04-27 7:33 ` Chao Yu via Linux-f2fs-devel
1 sibling, 0 replies; 3+ messages in thread
From: Chao Yu via Linux-f2fs-devel @ 2026-04-27 7:33 UTC (permalink / raw)
To: LuK1337, linux-f2fs-devel; +Cc: jaegeuk
On 3/13/26 21:09, LuK1337 wrote:
> From: Łukasz Patron <priv.luk@gmail.com>
>
> Fixes: a66d49fd2678 ("dump.f2fs: Dump symlinks as symlinks")
> Signed-off-by: Łukasz Patron <priv.luk@gmail.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-27 7:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-13 13:09 [f2fs-dev] [PATCH] dump.f2fs: macOS does not support lsetxattr LuK1337
2026-04-25 9:39 ` Łukasz Patron
2026-04-27 7:33 ` Chao Yu via Linux-f2fs-devel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox