[f2fs-dev] [PATCH] f2fs/015, 016: add missing _require_scratch checks

[f2fs-dev] [PATCH] f2fs/015, 016: add missing _require_scratch checks

[Prabhakar Pujeri via Linux-f2fs-devel]

Both tests run _scratch_mkfs in a loop without first requiring a scratch device, so they fail messily instead of skipping when no scratch device is configured.

Signed-off-by: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
---
 tests/f2fs/015 | 1 +
 tests/f2fs/016 | 1 +
 2 files changed, 2 insertions(+)

diff --git a/tests/f2fs/015 b/tests/f2fs/015
index 54cada4a..75ae91f2 100755
--- a/tests/f2fs/015
+++ b/tests/f2fs/015
@@ -12,6 +12,7 @@ _begin_fstest auto quick mount
 _require_kernel_config CONFIG_F2FS_FS_XATTR
 _require_kernel_config CONFIG_F2FS_FS_POSIX_ACL
 _require_kernel_config CONFIG_F2FS_FAULT_INJECTION
+_require_scratch
 
 options=(
 #	mount_option			mkfs_option
diff --git a/tests/f2fs/016 b/tests/f2fs/016
index a6df827d..e0857e0a 100755
--- a/tests/f2fs/016
+++ b/tests/f2fs/016
@@ -15,6 +15,7 @@ _require_kernel_config CONFIG_F2FS_FS_LZORLE
 _require_kernel_config CONFIG_F2FS_FS_LZ4
 _require_kernel_config CONFIG_F2FS_FS_LZ4HC
 _require_kernel_config CONFIG_F2FS_FS_ZSTD
+_require_scratch
 
 options=(
 #	mount_option			mkfs_option
-- 
2.55.0



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH] f2fs/015, 016: add missing _require_scratch checks

[Zorro Lang via Linux-f2fs-devel]

Oh, there's one more "add _require_scratch" related patch :)

On Wed, Sep 02, 2026 at 05:01:33AM +0000, Prabhakar Pujeri wrote:
> Both tests run _scratch_mkfs in a loop without first requiring a scratch device, so they fail messily instead of skipping when no scratch device is configured.

This line is too long. I can help to change that when I merge it.
Or *if you have more* similar patches, I can wait for your next
combined patch or patchset.

Reviewed-by: Zorro Lang <zlang@kernel.org>

> 
> Signed-off-by: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
> ---
>  tests/f2fs/015 | 1 +
>  tests/f2fs/016 | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/tests/f2fs/015 b/tests/f2fs/015
> index 54cada4a..75ae91f2 100755
> --- a/tests/f2fs/015
> +++ b/tests/f2fs/015
> @@ -12,6 +12,7 @@ _begin_fstest auto quick mount
>  _require_kernel_config CONFIG_F2FS_FS_XATTR
>  _require_kernel_config CONFIG_F2FS_FS_POSIX_ACL
>  _require_kernel_config CONFIG_F2FS_FAULT_INJECTION
> +_require_scratch
>  
>  options=(
>  #	mount_option			mkfs_option
> diff --git a/tests/f2fs/016 b/tests/f2fs/016
> index a6df827d..e0857e0a 100755
> --- a/tests/f2fs/016
> +++ b/tests/f2fs/016
> @@ -15,6 +15,7 @@ _require_kernel_config CONFIG_F2FS_FS_LZORLE
>  _require_kernel_config CONFIG_F2FS_FS_LZ4
>  _require_kernel_config CONFIG_F2FS_FS_LZ4HC
>  _require_kernel_config CONFIG_F2FS_FS_ZSTD
> +_require_scratch
>  
>  options=(
>  #	mount_option			mkfs_option
> -- 
> 2.55.0
> 


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel