* [PATCH] drivers/video/fbdev/atyfb: make const arrays static, reduces object code size
@ 2017-09-13 15:03 ` Colin King
2017-10-12 15:26 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-09-13 15:03 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, linux-fbdev; +Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Don't populate the const arrays ragepro_tbl and ragexl_tbl on the stack,
instead make them static. Makes the object code smaller by over 380 bytes:
Before:
text data bss dec hex filename
41089 10592 768 52449 cce1 atyfb_base.o
After:
text data bss dec hex filename
40544 10752 768 52064 cb60 atyfb_base.o
(gcc version 7.2.0, x86_64)
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/video/fbdev/aty/atyfb_base.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c
index 3ec72f19114b..a9a8272f7a6e 100644
--- a/drivers/video/fbdev/aty/atyfb_base.c
+++ b/drivers/video/fbdev/aty/atyfb_base.c
@@ -2272,10 +2272,10 @@ static void aty_bl_exit(struct backlight_device *bd)
static void aty_calc_mem_refresh(struct atyfb_par *par, int xclk)
{
- const int ragepro_tbl[] = {
+ static const int ragepro_tbl[] = {
44, 50, 55, 66, 75, 80, 100
};
- const int ragexl_tbl[] = {
+ static const int ragexl_tbl[] = {
50, 66, 75, 83, 90, 95, 100, 105,
110, 115, 120, 125, 133, 143, 166
};
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/video/fbdev/atyfb: make const arrays static, reduces object code size
2017-09-13 15:03 ` [PATCH] drivers/video/fbdev/atyfb: make const arrays static, reduces object code size Colin King
@ 2017-10-12 15:26 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-10-12 15:26 UTC (permalink / raw)
To: Colin King; +Cc: linux-fbdev, linux-kernel, dri-devel
On Wednesday, September 13, 2017 04:03:09 PM Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the const arrays ragepro_tbl and ragexl_tbl on the stack,
> instead make them static. Makes the object code smaller by over 380 bytes:
>
> Before:
> text data bss dec hex filename
> 41089 10592 768 52449 cce1 atyfb_base.o
>
> After:
> text data bss dec hex filename
> 40544 10752 768 52064 cb60 atyfb_base.o
>
> (gcc version 7.2.0, x86_64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch queued for 4.15 (with patch description fixed to
"video: fbdev: aty: ..." for consistency with other patches),
thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-12 15:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20170913150314epcas1p4257193707b94242110eb6b9b7a9fdd4b@epcas1p4.samsung.com>
2017-09-13 15:03 ` [PATCH] drivers/video/fbdev/atyfb: make const arrays static, reduces object code size Colin King
2017-10-12 15:26 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox