From: Damian Hobson-Garcia <dhobsong@igel.co.jp>
To: linux-fbdev@vger.kernel.org
Subject: [PATCH] fbdev: sh_mobile_lcdcfb: Change BGR24 to RGB24
Date: Thu, 26 May 2011 09:09:02 +0000 [thread overview]
Message-ID: <1306400942-26956-1-git-send-email-dhobsong@igel.co.jp> (raw)
The ordering of the bytes in the 24 bpp RGB colour mode was
being set to BGR.
This now matches the values returned in the
struct fb_var_screeninfo .red, .green, and .blue offsets as well as
the output format of other blocs, such as the VEU
Signed-off-by: Damian Hobson-Garcia <dhobsong@igel.co.jp>
---
drivers/video/sh_mobile_lcdcfb.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/sh_mobile_lcdcfb.c b/drivers/video/sh_mobile_lcdcfb.c
index 04f2260..a442471 100644
--- a/drivers/video/sh_mobile_lcdcfb.c
+++ b/drivers/video/sh_mobile_lcdcfb.c
@@ -590,7 +590,7 @@ static int sh_mobile_lcdc_start(struct sh_mobile_lcdc_priv *priv)
tmp |= 0x03;
break;
case 24:
- tmp |= 0x0b;
+ tmp |= 0x02;
break;
case 32:
break;
@@ -1178,7 +1178,7 @@ static int sh_mobile_lcdc_set_bpp(struct fb_var_screeninfo *var, int bpp,
var->transp.length = 0;
break;
- case 24: /* PKF[4:0] = 01011 - RGB 888 */
+ case 24: /* PKF[4:0] = 00010 - RGB 888 */
var->red.offset = 16;
var->red.length = 8;
var->green.offset = 8;
--
1.7.1
next reply other threads:[~2011-05-26 9:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 9:09 Damian Hobson-Garcia [this message]
2011-05-27 8:14 ` [PATCH] fbdev: sh_mobile_lcdcfb: Change BGR24 to RGB24 Magnus Damm
2011-05-31 3:28 ` Damian Hobson-Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306400942-26956-1-git-send-email-dhobsong@igel.co.jp \
--to=dhobsong@igel.co.jp \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox