Linux Framebuffer Layer development
 help / color / mirror / Atom feed
From: Damian Hobson-Garcia <dhobsong@igel.co.jp>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] fbdev: sh_mobile_lcdcfb: Change BGR24 to RGB24
Date: Tue, 31 May 2011 03:28:30 +0000	[thread overview]
Message-ID: <4DE4605E.6070102@igel.co.jp> (raw)
In-Reply-To: <1306400942-26956-1-git-send-email-dhobsong@igel.co.jp>

Hi Magnus,
On 2011/05/27 17:14, Magnus Damm wrote:
> Hi Damian,
> 
> On Thu, May 26, 2011 at 6:09 PM, Damian Hobson-Garcia
> <dhobsong@igel.co.jp> wrote:
>> The ordering of the bytes in the 24 bpp RGB colour mode was
>> being set to BGR.
>>
>> This now matches the values returned in the
>> struct fb_var_screeninfo .red, .green, and .blue offsets as well as
>> the output format of other blocs, such as the VEU
>>
>> Signed-off-by: Damian Hobson-Garcia <dhobsong@igel.co.jp>
>> ---
> 
> Thanks for your patch. With this change in place, is the fbdev console
> still working as expected?
> 
> Also, the byte swap settings in _LDDDSR are ok as-is?
Actually, let me look into this a bit more.  After thinking about it
some more there are one or two more things I want to check on this
first.  Please ignore this patch for now.  I'll resubmit it again once
its properly completed. Sorry for the mess.

Thanks,
Damian

      parent reply	other threads:[~2011-05-31  3:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-26  9:09 [PATCH] fbdev: sh_mobile_lcdcfb: Change BGR24 to RGB24 Damian Hobson-Garcia
2011-05-27  8:14 ` Magnus Damm
2011-05-31  3:28 ` Damian Hobson-Garcia [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DE4605E.6070102@igel.co.jp \
    --to=dhobsong@igel.co.jp \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox