* [PATCH] video: fbdev: sh_mipi_dsi.c: Cleaning up Boolean used in bitwise operation
@ 2014-07-02 21:57 Rickard Strandqvist
2014-07-02 21:57 ` Rickard Strandqvist
0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2014-07-02 21:57 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: Rickard Strandqvist, Jingoo Han, Laurent Pinchart, Rob Clark,
linux-fbdev, linux-kernel
Boolean variable is used in bitwise operation.
I personally find that this was pretty ugly, but think a solution like this yet is more correct.
This was found using a static code analysis program called cppcheck
Rickard Strandqvist (1):
video: fbdev: sh_mipi_dsi.c: Cleaning up Boolean used in bitwise operation
drivers/video/fbdev/sh_mipi_dsi.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
--
1.7.10.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] video: fbdev: sh_mipi_dsi.c: Cleaning up Boolean used in bitwise operation
2014-07-02 21:57 [PATCH] video: fbdev: sh_mipi_dsi.c: Cleaning up Boolean used in bitwise operation Rickard Strandqvist
@ 2014-07-02 21:57 ` Rickard Strandqvist
0 siblings, 0 replies; 2+ messages in thread
From: Rickard Strandqvist @ 2014-07-02 21:57 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: Rickard Strandqvist, Jingoo Han, Laurent Pinchart, Rob Clark,
linux-fbdev, linux-kernel
Boolean variable is used in bitwise operation.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/video/fbdev/sh_mipi_dsi.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/sh_mipi_dsi.c b/drivers/video/fbdev/sh_mipi_dsi.c
index 8f6e8ff..39417ab 100644
--- a/drivers/video/fbdev/sh_mipi_dsi.c
+++ b/drivers/video/fbdev/sh_mipi_dsi.c
@@ -113,11 +113,18 @@ static int sh_mipi_dcs_param(int handle, u8 cmd, u8 param)
static void sh_mipi_dsi_enable(struct sh_mipi *mipi, bool enable)
{
+ unsigned int enable_value;
+
+ if (enable)
+ enable_value = 0x00000003;
+ else
+ enable_value = 0x00000002;
+
/*
* enable LCDC data tx, transition to LPS after completion of each HS
* packet
*/
- iowrite32(0x00000002 | enable, mipi->linkbase + DTCTR);
+ iowrite32(enable_value, mipi->linkbase + DTCTR);
}
static void sh_mipi_shutdown(struct platform_device *pdev)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-02 21:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-02 21:57 [PATCH] video: fbdev: sh_mipi_dsi.c: Cleaning up Boolean used in bitwise operation Rickard Strandqvist
2014-07-02 21:57 ` Rickard Strandqvist
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox