* [PATCH] vmlfb: Fix error handling in cr_pll_init()
@ 2017-06-22 21:43 ` Alexey Khoroshilov
2017-07-04 14:14 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Khoroshilov @ 2017-06-22 21:43 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, Alan Hourihane
Cc: Alexey Khoroshilov, linux-fbdev, linux-kernel, ldv-project
There is an error path, where iomemory is left mapped.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
---
drivers/video/fbdev/vermilion/cr_pll.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/fbdev/vermilion/cr_pll.c b/drivers/video/fbdev/vermilion/cr_pll.c
index ebc6e6e0dd0f..ba105c876bed 100644
--- a/drivers/video/fbdev/vermilion/cr_pll.c
+++ b/drivers/video/fbdev/vermilion/cr_pll.c
@@ -185,6 +185,7 @@ static int __init cr_pll_init(void)
if (err) {
printk(KERN_ERR
"Carillo Ranch failed to initialize vml_sys.\n");
+ iounmap(mch_regs_base);
pci_dev_put(mch_dev);
return err;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] vmlfb: Fix error handling in cr_pll_init()
2017-06-22 21:43 ` [PATCH] vmlfb: Fix error handling in cr_pll_init() Alexey Khoroshilov
@ 2017-07-04 14:14 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-07-04 14:14 UTC (permalink / raw)
To: Alexey Khoroshilov; +Cc: Alan Hourihane, linux-fbdev, linux-kernel, ldv-project
On Friday, June 23, 2017 12:43:34 AM Alexey Khoroshilov wrote:
> There is an error path, where iomemory is left mapped.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Patch queued for 4.13, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-04 14:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20170622214347epcas4p12f0d1d6fad27b6b1ee41223329e3d8e2@epcas4p1.samsung.com>
2017-06-22 21:43 ` [PATCH] vmlfb: Fix error handling in cr_pll_init() Alexey Khoroshilov
2017-07-04 14:14 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox