* [PATCH] matroxfb_maven module OOPS on insmod
@ 2003-12-23 3:09 Kevin O'Connor
0 siblings, 0 replies; only message in thread
From: Kevin O'Connor @ 2003-12-23 3:09 UTC (permalink / raw)
To: vandrove, linux-fbdev-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 591 bytes --]
Hi,
When running the following commands:
/sbin/modprobe i2c-algo-bit
/sbin/modprobe i2c-matroxfb
/sbin/modprobe matroxfb_maven
the 2.6.0 kernel will reliably oops. The problem is a result of calling
device_add with uninitialized data. The following patch allows the module
to be inserted.
-Kevin
--
---------------------------------------------------------------------
| Kevin O'Connor "BTW, IMHO we need a FAQ for |
| kevin@koconnor.net 'IMHO', 'FAQ', 'BTW', etc. !" |
---------------------------------------------------------------------
[-- Attachment #2: matrox_diff --]
[-- Type: text/plain, Size: 416 bytes --]
--- gold-2.6/drivers/video/matrox/matroxfb_maven.c 2003-10-25 14:42:44.000000000 -0400
+++ linux-2.6.0/drivers/video/matrox/matroxfb_maven.c 2003-12-22 21:55:04.082725504 -0500
@@ -1249,6 +1249,7 @@
err = -ENOMEM;
goto ERROR0;
}
+ memset(new_client, 0, sizeof(*new_client) + sizeof(*data));
data = (struct maven_data*)(new_client + 1);
i2c_set_clientdata(new_client, data);
new_client->addr = address;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-12-23 3:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-12-23 3:09 [PATCH] matroxfb_maven module OOPS on insmod Kevin O'Connor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox