Re: [PATCH 1/2]Freescale i.MX framebuffer driver

["Antonino A. Daplas" <adaplas@hotpop.com>]

On Friday 18 March 2005 01:36, Sascha Hauer wrote:
> Hello all,
>
> This Patch adds support for the framebuffer on the freescale i.MX SOC
> architecture. The driver has been tested on the mx1ads board, the pimx1
> board and another custom board with different displays.

Preliminary comments:

1. Can you use framebuffer_alloc()?  Meaning you have to change this:

struct imxfb_info {
       struct fb_info          fb;
	...
}

Then put all driver private data in info->par.

2. Comment on putting the blank function in the workqueue:  The console
expects that after calling fbcon_blank/fb_blank, that the hardware is really
in that state.  For example, after calling unblank(), the console expects
that it is entirely safe to write to the device because it will do so.

If it is indeed safe to access the  device on all blank states, then yes, a
workqueue should be fine.

3. Also add a Signed-off-by line and submit the patch inline.

Tony





-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click