* [PATCH 0/3] sh_mobile_lcdc cleanup and fixes
@ 2011-07-15 21:52 Laurent Pinchart
2011-09-20 19:30 ` Laurent Pinchart
2011-09-20 19:33 ` Laurent Pinchart
0 siblings, 2 replies; 3+ messages in thread
From: Laurent Pinchart @ 2011-07-15 21:52 UTC (permalink / raw)
To: linux-fbdev
Hi everybody,
When trying to understand the sh_mobile_lcdc driver, I found it hard to read
statements that include hardcoded register values. I thus wrote a patch that
replace them with macros, making the code more readable.
While doing so, I found two potential issues in the driver. See patches 2 and
3 for detailed explanations and fixes.
Laurent Pinchart (3):
fbdev: sh_mobile_lcdc: Replace hardcoded register values with macros
fbdev: sh_mobile_lcdc: Don't acknowlege interrupts unintentionally
fbdev: sh_mobile_lcdc: Compute clock pattern using divider
denominator
drivers/video/sh_mobile_lcdcfb.c | 232 +++++++++++++++++---------------------
include/video/sh_mobile_lcdc.h | 135 +++++++++++++++++++---
2 files changed, 222 insertions(+), 145 deletions(-)
--
Best regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 0/3] sh_mobile_lcdc cleanup and fixes
2011-07-15 21:52 [PATCH 0/3] sh_mobile_lcdc cleanup and fixes Laurent Pinchart
@ 2011-09-20 19:30 ` Laurent Pinchart
2011-09-20 19:33 ` Laurent Pinchart
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2011-09-20 19:30 UTC (permalink / raw)
To: linux-fbdev
Hi Florian,
On Friday 15 July 2011 23:52:30 Laurent Pinchart wrote:
> Hi everybody,
>
> When trying to understand the sh_mobile_lcdc driver, I found it hard to
> read statements that include hardcoded register values. I thus wrote a
> patch that replace them with macros, making the code more readable.
>
> While doing so, I found two potential issues in the driver. See patches 2
> and 3 for detailed explanations and fixes.
>
> Laurent Pinchart (3):
> fbdev: sh_mobile_lcdc: Replace hardcoded register values with macros
> fbdev: sh_mobile_lcdc: Don't acknowlege interrupts unintentionally
> fbdev: sh_mobile_lcdc: Compute clock pattern using divider
> denominator
Could you please pick these patches for v3.2 ?
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 0/3] sh_mobile_lcdc cleanup and fixes
2011-07-15 21:52 [PATCH 0/3] sh_mobile_lcdc cleanup and fixes Laurent Pinchart
2011-09-20 19:30 ` Laurent Pinchart
@ 2011-09-20 19:33 ` Laurent Pinchart
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2011-09-20 19:33 UTC (permalink / raw)
To: linux-fbdev
On Tuesday 20 September 2011 21:30:15 Laurent Pinchart wrote:
> Hi Florian,
>
> On Friday 15 July 2011 23:52:30 Laurent Pinchart wrote:
> > Hi everybody,
> >
> > When trying to understand the sh_mobile_lcdc driver, I found it hard to
> > read statements that include hardcoded register values. I thus wrote a
> > patch that replace them with macros, making the code more readable.
> >
> > While doing so, I found two potential issues in the driver. See patches 2
> > and 3 for detailed explanations and fixes.
> >
> > Laurent Pinchart (3):
> > fbdev: sh_mobile_lcdc: Replace hardcoded register values with macros
> > fbdev: sh_mobile_lcdc: Don't acknowlege interrupts unintentionally
> > fbdev: sh_mobile_lcdc: Compute clock pattern using divider
> >
> > denominator
>
> Could you please pick these patches for v3.2 ?
Sorry, I meant to answer the next version of this patch set. Please pick v2
instead.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-20 19:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-15 21:52 [PATCH 0/3] sh_mobile_lcdc cleanup and fixes Laurent Pinchart
2011-09-20 19:30 ` Laurent Pinchart
2011-09-20 19:33 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox