* [PATCH] staging: sm7xxfb: Fix sparse warning
@ 2015-04-04 19:22 Nickolaus Woodruff
2015-04-04 19:31 ` Giedrius Statkevičius
0 siblings, 1 reply; 2+ messages in thread
From: Nickolaus Woodruff @ 2015-04-04 19:22 UTC (permalink / raw)
To: sudipmmukherjee, teddywang, gregkh; +Cc: linux-fbdev, devel, linux-kernel
This patch fixes the following sparse warning in sm7xx.h:
drivers/staging/sm7xxfb/sm7xx.h:122:17: warning: symbol 'vgamode'
was not declared. Should it be static?
Signed-off-by: Nickolaus Woodruff <nickolauswoodruff@gmail.com>
---
drivers/staging/sm7xxfb/sm7xx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm7xxfb/sm7xx.h b/drivers/staging/sm7xxfb/sm7xx.h
index 7cc1896..c5d6253 100644
--- a/drivers/staging/sm7xxfb/sm7xx.h
+++ b/drivers/staging/sm7xxfb/sm7xx.h
@@ -119,7 +119,7 @@ struct ModeInit {
/**********************************************************************
SM712 Mode table.
**********************************************************************/
-struct ModeInit vgamode[] = {
+static struct ModeInit vgamode[] = {
{
/* mode#0: 640 x 480 16Bpp 60Hz */
640, 480, 16, 60,
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: sm7xxfb: Fix sparse warning
2015-04-04 19:22 [PATCH] staging: sm7xxfb: Fix sparse warning Nickolaus Woodruff
@ 2015-04-04 19:31 ` Giedrius Statkevičius
0 siblings, 0 replies; 2+ messages in thread
From: Giedrius Statkevičius @ 2015-04-04 19:31 UTC (permalink / raw)
To: Nickolaus Woodruff
Cc: sudipmmukherjee, teddywang, gregkh, devel, linux-fbdev,
linux-kernel
On Sat, 4 Apr 2015, Nickolaus Woodruff wrote:
> This patch fixes the following sparse warning in sm7xx.h:
>
> drivers/staging/sm7xxfb/sm7xx.h:122:17: warning: symbol 'vgamode'
> was not declared. Should it be static?
>
> Signed-off-by: Nickolaus Woodruff <nickolauswoodruff@gmail.com>
> ---
> drivers/staging/sm7xxfb/sm7xx.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm7xxfb/sm7xx.h b/drivers/staging/sm7xxfb/sm7xx.h
> index 7cc1896..c5d6253 100644
> --- a/drivers/staging/sm7xxfb/sm7xx.h
> +++ b/drivers/staging/sm7xxfb/sm7xx.h
> @@ -119,7 +119,7 @@ struct ModeInit {
> /**********************************************************************
> SM712 Mode table.
> **********************************************************************/
> -struct ModeInit vgamode[] = {
> +static struct ModeInit vgamode[] = {
Someone already fixed this:
https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/tree/drivers/staging/sm7xxfb/sm7xx.h?h=staging-testing#n122
Please work against staging-testing branch of the staging tree.
Su pagarba / Regards,
Giedrius
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-04 19:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-04 19:22 [PATCH] staging: sm7xxfb: Fix sparse warning Nickolaus Woodruff
2015-04-04 19:31 ` Giedrius Statkevičius
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox