* [PATCH] video: fbdev: omap: Remove unnecessary print function dev_err()
@ 2022-08-24 11:44 Jiapeng Chong
2022-08-24 19:56 ` Helge Deller
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2022-08-24 11:44 UTC (permalink / raw)
To: deller
Cc: linux-fbdev, linux-omap, dri-devel, linux-kernel, Jiapeng Chong,
Abaci Robot
The print function dev_err() is redundant because platform_get_irq()
already prints an error.
./drivers/video/fbdev/omap/omapfb_main.c:1653:2-9: line 1653 is redundant because platform_get_irq() already prints an error.
./drivers/video/fbdev/omap/omapfb_main.c:1646:2-9: line 1646 is redundant because platform_get_irq() already prints an error.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1957
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/video/fbdev/omap/omapfb_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
index fbb3af883d4d..17cda5765683 100644
--- a/drivers/video/fbdev/omap/omapfb_main.c
+++ b/drivers/video/fbdev/omap/omapfb_main.c
@@ -1643,14 +1643,12 @@ static int omapfb_do_probe(struct platform_device *pdev,
}
fbdev->int_irq = platform_get_irq(pdev, 0);
if (fbdev->int_irq < 0) {
- dev_err(&pdev->dev, "unable to get irq\n");
r = ENXIO;
goto cleanup;
}
fbdev->ext_irq = platform_get_irq(pdev, 1);
if (fbdev->ext_irq < 0) {
- dev_err(&pdev->dev, "unable to get irq\n");
r = ENXIO;
goto cleanup;
}
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] video: fbdev: omap: Remove unnecessary print function dev_err()
2022-08-24 11:44 [PATCH] video: fbdev: omap: Remove unnecessary print function dev_err() Jiapeng Chong
@ 2022-08-24 19:56 ` Helge Deller
0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2022-08-24 19:56 UTC (permalink / raw)
To: Jiapeng Chong
Cc: linux-fbdev, linux-omap, dri-devel, linux-kernel, Abaci Robot
On 8/24/22 13:44, Jiapeng Chong wrote:
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> ./drivers/video/fbdev/omap/omapfb_main.c:1653:2-9: line 1653 is redundant because platform_get_irq() already prints an error.
> ./drivers/video/fbdev/omap/omapfb_main.c:1646:2-9: line 1646 is redundant because platform_get_irq() already prints an error.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1957
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
applied.
Thanks!
Helge
> ---
> drivers/video/fbdev/omap/omapfb_main.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
> index fbb3af883d4d..17cda5765683 100644
> --- a/drivers/video/fbdev/omap/omapfb_main.c
> +++ b/drivers/video/fbdev/omap/omapfb_main.c
> @@ -1643,14 +1643,12 @@ static int omapfb_do_probe(struct platform_device *pdev,
> }
> fbdev->int_irq = platform_get_irq(pdev, 0);
> if (fbdev->int_irq < 0) {
> - dev_err(&pdev->dev, "unable to get irq\n");
> r = ENXIO;
> goto cleanup;
> }
>
> fbdev->ext_irq = platform_get_irq(pdev, 1);
> if (fbdev->ext_irq < 0) {
> - dev_err(&pdev->dev, "unable to get irq\n");
> r = ENXIO;
> goto cleanup;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-24 19:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-24 11:44 [PATCH] video: fbdev: omap: Remove unnecessary print function dev_err() Jiapeng Chong
2022-08-24 19:56 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox