* [PATCH] nvidiafb: fix build on 32-bit ARCH=um
@ 2025-06-06 9:02 Johannes Berg
2025-06-06 19:24 ` Helge Deller
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2025-06-06 9:02 UTC (permalink / raw)
To: linux-kernel, linux-fbdev
Cc: dri-devel, Antonino Daplas, Helge Deller, Johannes Berg,
Arnd Bergmann
From: Johannes Berg <johannes.berg@intel.com>
Now that ARCH=um no longer has IO port accesses, this driver
can no longer build as-is. Make the IO port calls not just
conditional on i386 but also !UML.
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
drivers/video/fbdev/nvidia/nv_local.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/nvidia/nv_local.h b/drivers/video/fbdev/nvidia/nv_local.h
index 68e508daa417..93aff35305a9 100644
--- a/drivers/video/fbdev/nvidia/nv_local.h
+++ b/drivers/video/fbdev/nvidia/nv_local.h
@@ -80,7 +80,7 @@
(par)->dmaFree -= ((size) + 1); \
}
-#if defined(__i386__)
+#if defined(__i386__) && !defined(CONFIG_UML)
#define _NV_FENCE() outb(0, 0x3D0);
#else
#define _NV_FENCE() mb();
--
2.49.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] nvidiafb: fix build on 32-bit ARCH=um
2025-06-06 9:02 [PATCH] nvidiafb: fix build on 32-bit ARCH=um Johannes Berg
@ 2025-06-06 19:24 ` Helge Deller
0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2025-06-06 19:24 UTC (permalink / raw)
To: Johannes Berg, linux-kernel, linux-fbdev
Cc: dri-devel, Antonino Daplas, Johannes Berg, Arnd Bergmann
On 6/6/25 11:02, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> Now that ARCH=um no longer has IO port accesses, this driver
> can no longer build as-is. Make the IO port calls not just
> conditional on i386 but also !UML.
>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> drivers/video/fbdev/nvidia/nv_local.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to fbdev git tree.
Thanks!
Helge
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-06 17:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-06 9:02 [PATCH] nvidiafb: fix build on 32-bit ARCH=um Johannes Berg
2025-06-06 19:24 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox