* [PATCH] staging: sm750fb: fix CamelCase variables name in sm750
@ 2026-05-16 22:26 Emmanuel Arias
2026-05-17 2:57 ` kernel test robot
2026-05-17 4:00 ` kernel test robot
0 siblings, 2 replies; 3+ messages in thread
From: Emmanuel Arias @ 2026-05-16 22:26 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh
Cc: linux-fbdev, linux-staging, linux-kernel, Emmanuel Arias
Replace CamelCase variable name with snake_case:
- pvReg -> pv_reg
- setAllEngOff -> set_all_eng_off
Signed-off-by: Emmanuel Arias <eamanu@riseup.net>
---
drivers/staging/sm750fb/sm750.c | 6 +++---
drivers/staging/sm750fb/sm750.h | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 996a586a3727..9b30627a19d0 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -755,7 +755,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
* must be set after crtc member initialized
*/
crtc->cursor.offset = crtc->o_screen + crtc->vidmem_size - 1024;
- crtc->cursor.mmio = sm750_dev->pvReg +
+ crtc->cursor.mmio = sm750_dev->pv_reg +
0x800f0 + (int)crtc->channel * 0x140;
crtc->cursor.max_h = 64;
@@ -860,7 +860,7 @@ static void sm750fb_setup(struct sm750_dev *sm750_dev, char *src)
sm750_dev->init_parm.mem_clk = 0;
sm750_dev->init_parm.master_clk = 0;
sm750_dev->init_parm.power_mode = 0;
- sm750_dev->init_parm.setAllEngOff = 0;
+ sm750_dev->init_parm.set_all_eng_off = 0;
sm750_dev->init_parm.reset_memory = 1;
/* defaultly turn g_hwcursor on for both view */
@@ -1059,7 +1059,7 @@ static void lynxfb_pci_remove(struct pci_dev *pdev)
sm750fb_framebuffer_release(sm750_dev);
arch_phys_wc_del(sm750_dev->mtrr.vram);
- iounmap(sm750_dev->pvReg);
+ iounmap(sm750_dev->pv_reg);
iounmap(sm750_dev->vmem);
pci_release_region(pdev, 1);
kfree(g_settings);
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index d2c522e67f26..e8885133da2e 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -44,7 +44,7 @@ struct init_status {
ushort chip_clk;
ushort mem_clk;
ushort master_clk;
- ushort setAllEngOff;
+ ushort set_all_eng_off;
ushort reset_memory;
};
@@ -97,7 +97,7 @@ struct sm750_dev {
unsigned long vidreg_start;
__u32 vidmem_size;
__u32 vidreg_size;
- void __iomem *pvReg;
+ void __iomem *pv_reg;
unsigned char __iomem *vmem;
/* locks*/
spinlock_t slock;
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: sm750fb: fix CamelCase variables name in sm750
2026-05-16 22:26 [PATCH] staging: sm750fb: fix CamelCase variables name in sm750 Emmanuel Arias
@ 2026-05-17 2:57 ` kernel test robot
2026-05-17 4:00 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2026-05-17 2:57 UTC (permalink / raw)
To: Emmanuel Arias, sudipm.mukherjee, teddy.wang, gregkh
Cc: oe-kbuild-all, linux-fbdev, linux-staging, linux-kernel,
Emmanuel Arias
Hi Emmanuel,
kernel test robot noticed the following build errors:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/Emmanuel-Arias/staging-sm750fb-fix-CamelCase-variables-name-in-sm750/20260517-062807
base: staging/staging-testing
patch link: https://lore.kernel.org/r/20260516222613.1178800-1-eamanu%40riseup.net
patch subject: [PATCH] staging: sm750fb: fix CamelCase variables name in sm750
config: parisc-randconfig-002-20260517 (https://download.01.org/0day-ci/archive/20260517/202605171049.KbaBnrJV-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260517/202605171049.KbaBnrJV-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605171049.KbaBnrJV-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/staging/sm750fb/sm750_hw.c: In function 'hw_sm750_map':
>> drivers/staging/sm750fb/sm750_hw.c:43:13: error: 'struct sm750_dev' has no member named 'pvReg'; did you mean 'pv_reg'?
sm750_dev->pvReg =
^~~~~
pv_reg
drivers/staging/sm750fb/sm750_hw.c:45:18: error: 'struct sm750_dev' has no member named 'pvReg'; did you mean 'pv_reg'?
if (!sm750_dev->pvReg) {
^~~~~
pv_reg
drivers/staging/sm750fb/sm750_hw.c:51:41: error: 'struct sm750_dev' has no member named 'pvReg'; did you mean 'pv_reg'?
sm750_dev->accel.dpr_base = sm750_dev->pvReg + DE_BASE_ADDR_TYPE1;
^~~~~
pv_reg
drivers/staging/sm750fb/sm750_hw.c:52:45: error: 'struct sm750_dev' has no member named 'pvReg'; did you mean 'pv_reg'?
sm750_dev->accel.dp_port_base = sm750_dev->pvReg + DE_PORT_ADDR_TYPE1;
^~~~~
pv_reg
drivers/staging/sm750fb/sm750_hw.c:54:23: error: 'struct sm750_dev' has no member named 'pvReg'; did you mean 'pv_reg'?
mmio750 = sm750_dev->pvReg;
^~~~~
pv_reg
drivers/staging/sm750fb/sm750_hw.c:78:21: error: 'struct sm750_dev' has no member named 'pvReg'; did you mean 'pv_reg'?
iounmap(sm750_dev->pvReg);
^~~~~
pv_reg
vim +43 drivers/staging/sm750fb/sm750_hw.c
efe9bc08bf479b Elise Lennion 2016-10-11 27
700591a9adc8b1 Mike Rapoport 2015-10-26 28 int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev)
81dee67e215b23 Sudip Mukherjee 2015-03-03 29 {
81dee67e215b23 Sudip Mukherjee 2015-03-03 30 int ret;
81dee67e215b23 Sudip Mukherjee 2015-03-03 31
e359b6a863e19f Mike Rapoport 2015-10-26 32 sm750_dev->vidreg_start = pci_resource_start(pdev, 1);
e359b6a863e19f Mike Rapoport 2015-10-26 33 sm750_dev->vidreg_size = SZ_2M;
81dee67e215b23 Sudip Mukherjee 2015-03-03 34
8225489ddb9006 Artem Lytkin 2026-02-16 35 /* reserve the vidreg space of smi adaptor */
9a52ae2dd8c24a Anatoly Stepanov 2015-06-29 36 ret = pci_request_region(pdev, 1, "sm750fb");
9a52ae2dd8c24a Anatoly Stepanov 2015-06-29 37 if (ret) {
e5448f8d2ec5b4 Artem Lytkin 2026-02-23 38 dev_err(&pdev->dev, "Can not request PCI regions.\n");
8225489ddb9006 Artem Lytkin 2026-02-16 39 return ret;
81dee67e215b23 Sudip Mukherjee 2015-03-03 40 }
81dee67e215b23 Sudip Mukherjee 2015-03-03 41
81dee67e215b23 Sudip Mukherjee 2015-03-03 42 /* now map mmio and vidmem */
fdc234d85210d9 Benjamin Philip 2021-07-28 @43 sm750_dev->pvReg =
fdc234d85210d9 Benjamin Philip 2021-07-28 44 ioremap(sm750_dev->vidreg_start, sm750_dev->vidreg_size);
e359b6a863e19f Mike Rapoport 2015-10-26 45 if (!sm750_dev->pvReg) {
e5448f8d2ec5b4 Artem Lytkin 2026-02-23 46 dev_err(&pdev->dev, "mmio failed\n");
81dee67e215b23 Sudip Mukherjee 2015-03-03 47 ret = -EFAULT;
8225489ddb9006 Artem Lytkin 2026-02-16 48 goto err_release_region;
81dee67e215b23 Sudip Mukherjee 2015-03-03 49 }
81dee67e215b23 Sudip Mukherjee 2015-03-03 50
5865a858dbc9cb Yiming Qian 2025-09-09 51 sm750_dev->accel.dpr_base = sm750_dev->pvReg + DE_BASE_ADDR_TYPE1;
5865a858dbc9cb Yiming Qian 2025-09-09 52 sm750_dev->accel.dp_port_base = sm750_dev->pvReg + DE_PORT_ADDR_TYPE1;
81dee67e215b23 Sudip Mukherjee 2015-03-03 53
efe9bc08bf479b Elise Lennion 2016-10-11 54 mmio750 = sm750_dev->pvReg;
efe9bc08bf479b Elise Lennion 2016-10-11 55 sm750_set_chip_type(sm750_dev->devid, sm750_dev->revid);
81dee67e215b23 Sudip Mukherjee 2015-03-03 56
e359b6a863e19f Mike Rapoport 2015-10-26 57 sm750_dev->vidmem_start = pci_resource_start(pdev, 0);
f5016082f63d42 Eric S. Stone 2016-10-22 58 /*
f5016082f63d42 Eric S. Stone 2016-10-22 59 * don't use pdev_resource[x].end - resource[x].start to
878336c3362d09 Stefan Wolz 2016-06-23 60 * calculate the resource size, it's only the maximum available
878336c3362d09 Stefan Wolz 2016-06-23 61 * size but not the actual size, using
3fcb465f1e74ef Elise Lennion 2016-10-13 62 * @ddk750_get_vm_size function can be safe.
878336c3362d09 Stefan Wolz 2016-06-23 63 */
3fcb465f1e74ef Elise Lennion 2016-10-13 64 sm750_dev->vidmem_size = ddk750_get_vm_size();
81dee67e215b23 Sudip Mukherjee 2015-03-03 65
81dee67e215b23 Sudip Mukherjee 2015-03-03 66 /* reserve the vidmem space of smi adaptor */
f50b4602fea62f Jennifer Guo 2026-05-09 67 sm750_dev->vmem =
fdc234d85210d9 Benjamin Philip 2021-07-28 68 ioremap_wc(sm750_dev->vidmem_start, sm750_dev->vidmem_size);
f50b4602fea62f Jennifer Guo 2026-05-09 69 if (!sm750_dev->vmem) {
e5448f8d2ec5b4 Artem Lytkin 2026-02-23 70 dev_err(&pdev->dev, "Map video memory failed\n");
81dee67e215b23 Sudip Mukherjee 2015-03-03 71 ret = -EFAULT;
8225489ddb9006 Artem Lytkin 2026-02-16 72 goto err_unmap_reg;
81dee67e215b23 Sudip Mukherjee 2015-03-03 73 }
8225489ddb9006 Artem Lytkin 2026-02-16 74
8225489ddb9006 Artem Lytkin 2026-02-16 75 return 0;
8225489ddb9006 Artem Lytkin 2026-02-16 76
8225489ddb9006 Artem Lytkin 2026-02-16 77 err_unmap_reg:
8225489ddb9006 Artem Lytkin 2026-02-16 78 iounmap(sm750_dev->pvReg);
8225489ddb9006 Artem Lytkin 2026-02-16 79 err_release_region:
8225489ddb9006 Artem Lytkin 2026-02-16 80 pci_release_region(pdev, 1);
81dee67e215b23 Sudip Mukherjee 2015-03-03 81 return ret;
81dee67e215b23 Sudip Mukherjee 2015-03-03 82 }
81dee67e215b23 Sudip Mukherjee 2015-03-03 83
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: sm750fb: fix CamelCase variables name in sm750
2026-05-16 22:26 [PATCH] staging: sm750fb: fix CamelCase variables name in sm750 Emmanuel Arias
2026-05-17 2:57 ` kernel test robot
@ 2026-05-17 4:00 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2026-05-17 4:00 UTC (permalink / raw)
To: Emmanuel Arias, sudipm.mukherjee, teddy.wang, gregkh
Cc: llvm, oe-kbuild-all, linux-fbdev, linux-staging, linux-kernel,
Emmanuel Arias
Hi Emmanuel,
kernel test robot noticed the following build errors:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/Emmanuel-Arias/staging-sm750fb-fix-CamelCase-variables-name-in-sm750/20260517-062807
base: staging/staging-testing
patch link: https://lore.kernel.org/r/20260516222613.1178800-1-eamanu%40riseup.net
patch subject: [PATCH] staging: sm750fb: fix CamelCase variables name in sm750
config: riscv-randconfig-001-20260517 (https://download.01.org/0day-ci/archive/20260517/202605171120.K414qtus-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project 5bac06718f502014fade905512f1d26d578a18f3)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260517/202605171120.K414qtus-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605171120.K414qtus-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/staging/sm750fb/sm750_hw.c:43:13: error: no member named 'pvReg' in 'struct sm750_dev'
43 | sm750_dev->pvReg =
| ~~~~~~~~~ ^
drivers/staging/sm750fb/sm750_hw.c:45:18: error: no member named 'pvReg' in 'struct sm750_dev'
45 | if (!sm750_dev->pvReg) {
| ~~~~~~~~~ ^
drivers/staging/sm750fb/sm750_hw.c:51:41: error: no member named 'pvReg' in 'struct sm750_dev'
51 | sm750_dev->accel.dpr_base = sm750_dev->pvReg + DE_BASE_ADDR_TYPE1;
| ~~~~~~~~~ ^
drivers/staging/sm750fb/sm750_hw.c:52:45: error: no member named 'pvReg' in 'struct sm750_dev'
52 | sm750_dev->accel.dp_port_base = sm750_dev->pvReg + DE_PORT_ADDR_TYPE1;
| ~~~~~~~~~ ^
drivers/staging/sm750fb/sm750_hw.c:54:23: error: no member named 'pvReg' in 'struct sm750_dev'
54 | mmio750 = sm750_dev->pvReg;
| ~~~~~~~~~ ^
drivers/staging/sm750fb/sm750_hw.c:78:21: error: no member named 'pvReg' in 'struct sm750_dev'
78 | iounmap(sm750_dev->pvReg);
| ~~~~~~~~~ ^
6 errors generated.
vim +43 drivers/staging/sm750fb/sm750_hw.c
efe9bc08bf479b Elise Lennion 2016-10-11 27
700591a9adc8b1 Mike Rapoport 2015-10-26 28 int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev)
81dee67e215b23 Sudip Mukherjee 2015-03-03 29 {
81dee67e215b23 Sudip Mukherjee 2015-03-03 30 int ret;
81dee67e215b23 Sudip Mukherjee 2015-03-03 31
e359b6a863e19f Mike Rapoport 2015-10-26 32 sm750_dev->vidreg_start = pci_resource_start(pdev, 1);
e359b6a863e19f Mike Rapoport 2015-10-26 33 sm750_dev->vidreg_size = SZ_2M;
81dee67e215b23 Sudip Mukherjee 2015-03-03 34
8225489ddb9006 Artem Lytkin 2026-02-16 35 /* reserve the vidreg space of smi adaptor */
9a52ae2dd8c24a Anatoly Stepanov 2015-06-29 36 ret = pci_request_region(pdev, 1, "sm750fb");
9a52ae2dd8c24a Anatoly Stepanov 2015-06-29 37 if (ret) {
e5448f8d2ec5b4 Artem Lytkin 2026-02-23 38 dev_err(&pdev->dev, "Can not request PCI regions.\n");
8225489ddb9006 Artem Lytkin 2026-02-16 39 return ret;
81dee67e215b23 Sudip Mukherjee 2015-03-03 40 }
81dee67e215b23 Sudip Mukherjee 2015-03-03 41
81dee67e215b23 Sudip Mukherjee 2015-03-03 42 /* now map mmio and vidmem */
fdc234d85210d9 Benjamin Philip 2021-07-28 @43 sm750_dev->pvReg =
fdc234d85210d9 Benjamin Philip 2021-07-28 44 ioremap(sm750_dev->vidreg_start, sm750_dev->vidreg_size);
e359b6a863e19f Mike Rapoport 2015-10-26 45 if (!sm750_dev->pvReg) {
e5448f8d2ec5b4 Artem Lytkin 2026-02-23 46 dev_err(&pdev->dev, "mmio failed\n");
81dee67e215b23 Sudip Mukherjee 2015-03-03 47 ret = -EFAULT;
8225489ddb9006 Artem Lytkin 2026-02-16 48 goto err_release_region;
81dee67e215b23 Sudip Mukherjee 2015-03-03 49 }
81dee67e215b23 Sudip Mukherjee 2015-03-03 50
5865a858dbc9cb Yiming Qian 2025-09-09 51 sm750_dev->accel.dpr_base = sm750_dev->pvReg + DE_BASE_ADDR_TYPE1;
5865a858dbc9cb Yiming Qian 2025-09-09 52 sm750_dev->accel.dp_port_base = sm750_dev->pvReg + DE_PORT_ADDR_TYPE1;
81dee67e215b23 Sudip Mukherjee 2015-03-03 53
efe9bc08bf479b Elise Lennion 2016-10-11 54 mmio750 = sm750_dev->pvReg;
efe9bc08bf479b Elise Lennion 2016-10-11 55 sm750_set_chip_type(sm750_dev->devid, sm750_dev->revid);
81dee67e215b23 Sudip Mukherjee 2015-03-03 56
e359b6a863e19f Mike Rapoport 2015-10-26 57 sm750_dev->vidmem_start = pci_resource_start(pdev, 0);
f5016082f63d42 Eric S. Stone 2016-10-22 58 /*
f5016082f63d42 Eric S. Stone 2016-10-22 59 * don't use pdev_resource[x].end - resource[x].start to
878336c3362d09 Stefan Wolz 2016-06-23 60 * calculate the resource size, it's only the maximum available
878336c3362d09 Stefan Wolz 2016-06-23 61 * size but not the actual size, using
3fcb465f1e74ef Elise Lennion 2016-10-13 62 * @ddk750_get_vm_size function can be safe.
878336c3362d09 Stefan Wolz 2016-06-23 63 */
3fcb465f1e74ef Elise Lennion 2016-10-13 64 sm750_dev->vidmem_size = ddk750_get_vm_size();
81dee67e215b23 Sudip Mukherjee 2015-03-03 65
81dee67e215b23 Sudip Mukherjee 2015-03-03 66 /* reserve the vidmem space of smi adaptor */
f50b4602fea62f Jennifer Guo 2026-05-09 67 sm750_dev->vmem =
fdc234d85210d9 Benjamin Philip 2021-07-28 68 ioremap_wc(sm750_dev->vidmem_start, sm750_dev->vidmem_size);
f50b4602fea62f Jennifer Guo 2026-05-09 69 if (!sm750_dev->vmem) {
e5448f8d2ec5b4 Artem Lytkin 2026-02-23 70 dev_err(&pdev->dev, "Map video memory failed\n");
81dee67e215b23 Sudip Mukherjee 2015-03-03 71 ret = -EFAULT;
8225489ddb9006 Artem Lytkin 2026-02-16 72 goto err_unmap_reg;
81dee67e215b23 Sudip Mukherjee 2015-03-03 73 }
8225489ddb9006 Artem Lytkin 2026-02-16 74
8225489ddb9006 Artem Lytkin 2026-02-16 75 return 0;
8225489ddb9006 Artem Lytkin 2026-02-16 76
8225489ddb9006 Artem Lytkin 2026-02-16 77 err_unmap_reg:
8225489ddb9006 Artem Lytkin 2026-02-16 78 iounmap(sm750_dev->pvReg);
8225489ddb9006 Artem Lytkin 2026-02-16 79 err_release_region:
8225489ddb9006 Artem Lytkin 2026-02-16 80 pci_release_region(pdev, 1);
81dee67e215b23 Sudip Mukherjee 2015-03-03 81 return ret;
81dee67e215b23 Sudip Mukherjee 2015-03-03 82 }
81dee67e215b23 Sudip Mukherjee 2015-03-03 83
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-17 4:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-16 22:26 [PATCH] staging: sm750fb: fix CamelCase variables name in sm750 Emmanuel Arias
2026-05-17 2:57 ` kernel test robot
2026-05-17 4:00 ` kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox