From: "Alberto Aróstegui" <aarosteguig@gmail.com>
To: Helge Deller <deller@gmx.de>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
AlbertoArostegui <aarosteguig@gmail.com>
Subject: [PATCH] fbdev: pxa168fb: use devm_ioremap_resource() for MMIO
Date: Wed, 27 May 2026 15:39:13 +0000 [thread overview]
Message-ID: <20260527153913.33342-1-aarosteguig@gmail.com> (raw)
From: AlbertoArostegui <aarosteguig@gmail.com>
pxa168fb maps the LCD controller register resource with devm_ioremap(),
which does not request the memory region. Use devm_ioremap_resource()
instead so the MMIO range is claimed before being mapped.
This also handles cleanup automatically.
Signed-off-by: AlbertoArostegui <aarosteguig@gmail.com>
---
drivers/video/fbdev/pxa168fb.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/video/fbdev/pxa168fb.c b/drivers/video/fbdev/pxa168fb.c
index ec602f7776eb..6784888d93c9 100644
--- a/drivers/video/fbdev/pxa168fb.c
+++ b/drivers/video/fbdev/pxa168fb.c
@@ -653,10 +653,9 @@ static int pxa168fb_probe(struct platform_device *pdev)
/*
* Map LCD controller registers.
*/
- fbi->reg_base = devm_ioremap(&pdev->dev, res->start,
- resource_size(res));
- if (fbi->reg_base == NULL) {
- ret = -ENOMEM;
+ fbi->reg_base = devm_ioremap_resource(&pdev->dev, res);
+ if (IS_ERR(fbi->reg_base)) {
+ ret = PTR_ERR(fbi->reg_base);
goto failed_free_info;
}
--
2.43.0
reply other threads:[~2026-05-27 15:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260527153913.33342-1-aarosteguig@gmail.com \
--to=aarosteguig@gmail.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox