* [PATCH] fbdev: pxa168fb: use devm_ioremap_resource() for MMIO
@ 2026-05-27 15:39 Alberto Aróstegui
0 siblings, 0 replies; only message in thread
From: Alberto Aróstegui @ 2026-05-27 15:39 UTC (permalink / raw)
To: Helge Deller; +Cc: linux-fbdev, dri-devel, AlbertoArostegui
From: AlbertoArostegui <aarosteguig@gmail.com>
pxa168fb maps the LCD controller register resource with devm_ioremap(),
which does not request the memory region. Use devm_ioremap_resource()
instead so the MMIO range is claimed before being mapped.
This also handles cleanup automatically.
Signed-off-by: AlbertoArostegui <aarosteguig@gmail.com>
---
drivers/video/fbdev/pxa168fb.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/video/fbdev/pxa168fb.c b/drivers/video/fbdev/pxa168fb.c
index ec602f7776eb..6784888d93c9 100644
--- a/drivers/video/fbdev/pxa168fb.c
+++ b/drivers/video/fbdev/pxa168fb.c
@@ -653,10 +653,9 @@ static int pxa168fb_probe(struct platform_device *pdev)
/*
* Map LCD controller registers.
*/
- fbi->reg_base = devm_ioremap(&pdev->dev, res->start,
- resource_size(res));
- if (fbi->reg_base == NULL) {
- ret = -ENOMEM;
+ fbi->reg_base = devm_ioremap_resource(&pdev->dev, res);
+ if (IS_ERR(fbi->reg_base)) {
+ ret = PTR_ERR(fbi->reg_base);
goto failed_free_info;
}
--
2.43.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-05-27 15:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-27 15:39 [PATCH] fbdev: pxa168fb: use devm_ioremap_resource() for MMIO Alberto Aróstegui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox