* [PATCH] fbdev: clps711x-fb: Remove unreachable unregister_framebuffer() call
@ 2026-08-08 14:41 Karl Mehltretter
2026-08-08 15:17 ` Helge Deller
0 siblings, 1 reply; 2+ messages in thread
From: Karl Mehltretter @ 2026-08-08 14:41 UTC (permalink / raw)
To: Helge Deller
Cc: Karl Mehltretter, Thomas Zimmermann, linux-fbdev, dri-devel,
linux-kernel
The unregister_framebuffer() call in clps711x_fb_probe() is unreachable.
register_framebuffer() failure jumps to the unwind label, while success
returns immediately.
Remove it.
Found with Clang's -Wunreachable-code.
Fixes: 36462ac193088 ("fbdev: clps711x-fb: Replace check_fb in favor of struct fb_info.lcd_dev")
Assisted-by: Claude:claude-fable-5
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
drivers/video/fbdev/clps711x-fb.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/video/fbdev/clps711x-fb.c b/drivers/video/fbdev/clps711x-fb.c
index 7a7db7100499e..6789773b22fbe 100644
--- a/drivers/video/fbdev/clps711x-fb.c
+++ b/drivers/video/fbdev/clps711x-fb.c
@@ -329,8 +329,6 @@ static int clps711x_fb_probe(struct platform_device *pdev)
return 0;
- unregister_framebuffer(info);
-
out_fb_dealloc_cmap:
regmap_update_bits(cfb->syscon, SYSCON_OFFSET, SYSCON1_LCDEN, 0);
fb_dealloc_cmap(&info->cmap);
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fbdev: clps711x-fb: Remove unreachable unregister_framebuffer() call
2026-08-08 14:41 [PATCH] fbdev: clps711x-fb: Remove unreachable unregister_framebuffer() call Karl Mehltretter
@ 2026-08-08 15:17 ` Helge Deller
0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2026-08-08 15:17 UTC (permalink / raw)
To: Karl Mehltretter; +Cc: Thomas Zimmermann, linux-fbdev, dri-devel, linux-kernel
On 8/8/26 16:41, Karl Mehltretter wrote:
> The unregister_framebuffer() call in clps711x_fb_probe() is unreachable.
> register_framebuffer() failure jumps to the unwind label, while success
> returns immediately.
>
> Remove it.
>
> Found with Clang's -Wunreachable-code.
>
> Fixes: 36462ac193088 ("fbdev: clps711x-fb: Replace check_fb in favor of struct fb_info.lcd_dev")
> Assisted-by: Claude:claude-fable-5
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
> drivers/video/fbdev/clps711x-fb.c | 2 --
> 1 file changed, 2 deletions(-)
applied.
Thanks!
Helge
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-08 15:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-08 14:41 [PATCH] fbdev: clps711x-fb: Remove unreachable unregister_framebuffer() call Karl Mehltretter
2026-08-08 15:17 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox