[PATCH] staging: fbtft: fix spacing in macro calls

[PATCH] staging: fbtft: fix spacing in macro calls

[krishnanand G]

From 5473fd52eeda7ab1f608c414e386dad0ea40bef4 Mon Sep 17 00:00:00 2001
From: Krishnanand G <118352827+Krishnanand-G@users.noreply.github.com>
Date: Sat, 26 Sep 2026 19:41:06 +0530
Subject: [PATCH] staging: fbtft: fix spacing in macro calls

The two calls to define_fbtft_write_reg() that use the default
modifier have a space before the closing parenthesis. This triggers
two checkpatch.pl errors.

Add an inline comment for the intentionally empty modifier argument.
It satisfies the spacing check without changing the macro expansion.

Tests: scripts/checkpatch.pl --no-tree -f --terse --strict
  drivers/staging/fbtft/fbtft-bus.c
Signed-off-by: Krishnanand G <118352827+Krishnanand-G@users.noreply.github.com>
Assisted-by: LLM
---
 drivers/staging/fbtft/fbtft-bus.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/fbtft/fbtft-bus.c
b/drivers/staging/fbtft/fbtft-bus.c
index 30e436f..5f320de 100644
--- a/drivers/staging/fbtft/fbtft-bus.c
+++ b/drivers/staging/fbtft/fbtft-bus.c
@@ -62,9 +62,9 @@ out:									      \
 }                                                                             \
 EXPORT_SYMBOL(func);

-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, /* no modifier */)
 define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, /* no modifier */)

 void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
 {
-- 
2.39.0.windows.2

Re: [PATCH] staging: fbtft: fix spacing in macro calls

[Greg KH]

On Sun, Sep 27, 2026 at 02:48:40AM -0700, krishnanand G wrote:
> >From 5473fd52eeda7ab1f608c414e386dad0ea40bef4 Mon Sep 17 00:00:00 2001
> From: Krishnanand G <118352827+Krishnanand-G@users.noreply.github.com>
> Date: Sat, 26 Sep 2026 19:41:06 +0530
> Subject: [PATCH] staging: fbtft: fix spacing in macro calls
> 
> The two calls to define_fbtft_write_reg() that use the default
> modifier have a space before the closing parenthesis. This triggers
> two checkpatch.pl errors.
> 
> Add an inline comment for the intentionally empty modifier argument.
> It satisfies the spacing check without changing the macro expansion.
> 
> Tests: scripts/checkpatch.pl --no-tree -f --terse --strict
>   drivers/staging/fbtft/fbtft-bus.c
> Signed-off-by: Krishnanand G <118352827+Krishnanand-G@users.noreply.github.com>
> Assisted-by: LLM

Please read the email archives for why both this will not work, AND why
you can not use LLMs on this part of the kernel.

Also, your email address isn't valid :(

Re: [PATCH] staging: fbtft: fix spacing in macro calls

[gregkh]

On Sat, Sep 26, 2026 at 08:02:38PM +0530, krishnanand G wrote:
> The two calls to define_fbtft_write_reg() that use the default
> modifier have a space before the closing parenthesis. This triggers
> two checkpatch.pl errors.
> 
> Add an inline comment for the intentionally empty modifier argument.
> It satisfies the spacing check without changing the macro expansion.
> 
> Tests: scripts/checkpatch.pl --no-tree -f --terse --strict
>   drivers/staging/fbtft/fbtft-bus.c
> 
> A full kernel build was not run because the sparse checkout does not
> include the architecture makefiles.

Do not ever work with sparse checkouts,that's not how to do kernel
development.

> Signed-off-by: Krishnanand G <
> 118352827+Krishnanand-G@users.noreply.github.com>

There is no patch here :(