* [PATCH] fbdev: au1100fb: drop unneeded semicolon
@ 2026-08-01 19:09 Julia Lawall
2026-08-01 20:34 ` Helge Deller
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2026-08-01 19:09 UTC (permalink / raw)
To: Helge Deller; +Cc: kernel-janitors, linux-fbdev, dri-devel, linux-kernel
When a function-like macro expands to an expression, that expression
doesn't need a semicolon after it. All uses have been verified to
have their own semicolons.
This was found using the following Coccinelle semantic patch:
@r@
identifier i : script:ocaml() { String.lowercase_ascii i = i };
expression e;
@@
*#define i(...) e;
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
---
drivers/video/fbdev/au1100fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/au1100fb.c b/drivers/video/fbdev/au1100fb.c
index c54cfcd83..39f86ffb1 100644
--- a/drivers/video/fbdev/au1100fb.c
+++ b/drivers/video/fbdev/au1100fb.c
@@ -393,7 +393,7 @@ static struct au1100fb_panel known_lcd_panels[] =
#define DRIVER_DESC "LCD controller driver for AU1100 processors"
#define to_au1100fb_device(_info) \
- (_info ? container_of(_info, struct au1100fb_device, info) : NULL);
+ (_info ? container_of(_info, struct au1100fb_device, info) : NULL)
/* Bitfields format supported by the controller. Note that the order of formats
* SHOULD be the same as in the LCD_CONTROL_SBPPF field, so we can retrieve the
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fbdev: au1100fb: drop unneeded semicolon
2026-08-01 19:09 [PATCH] fbdev: au1100fb: drop unneeded semicolon Julia Lawall
@ 2026-08-01 20:34 ` Helge Deller
0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2026-08-01 20:34 UTC (permalink / raw)
To: Julia Lawall; +Cc: kernel-janitors, linux-fbdev, dri-devel, linux-kernel
On 8/1/26 21:09, Julia Lawall wrote:
> When a function-like macro expands to an expression, that expression
> doesn't need a semicolon after it. All uses have been verified to
> have their own semicolons.
>
> This was found using the following Coccinelle semantic patch:
>
> @r@
> identifier i : script:ocaml() { String.lowercase_ascii i = i };
> expression e;
> @@
>
> *#define i(...) e;
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
>
> ---
> drivers/video/fbdev/au1100fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
applied.
Thanks!
Helge
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-01 20:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-01 19:09 [PATCH] fbdev: au1100fb: drop unneeded semicolon Julia Lawall
2026-08-01 20:34 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).