* [PATCH 01/28] video: fbdev: radeon: constify pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
@ 2017-07-20 17:51 ` Arvind Yadav
2017-07-20 17:51 ` [PATCH 02/28] video: fbdev: atyfb: " Arvind Yadav
` (27 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-07-20 17:51 UTC (permalink / raw)
To: b.zolnierkie, paulus, benh, adaplas, mbroemme, FlorianSchandinat
Cc: linux-fbdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
19709 5024 32 24765 60bd video/fbdev/aty/radeon_base.o
File size After adding 'const':
text data bss dec hex filename
22893 1840 32 24765 60bd video/fbdev/aty/radeon_base.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/aty/radeon_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c
index 6b4c787..dba479e 100644
--- a/drivers/video/fbdev/aty/radeon_base.c
+++ b/drivers/video/fbdev/aty/radeon_base.c
@@ -96,7 +96,7 @@
#define CHIP_DEF(id, family, flags) \
{ PCI_VENDOR_ID_ATI, id, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (flags) | (CHIP_FAMILY_##family) }
-static struct pci_device_id radeonfb_pci_table[] = {
+static const struct pci_device_id radeonfb_pci_table[] = {
/* Radeon Xpress 200m */
CHIP_DEF(PCI_CHIP_RS480_5955, RS480, CHIP_HAS_CRTC2 | CHIP_IS_IGP | CHIP_IS_MOBILITY),
CHIP_DEF(PCI_CHIP_RS482_5975, RS480, CHIP_HAS_CRTC2 | CHIP_IS_IGP | CHIP_IS_MOBILITY),
--
2.7.4
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 02/28] video: fbdev: atyfb: constify pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
2017-07-20 17:51 ` [PATCH 01/28] video: fbdev: radeon: constify pci_device_id Arvind Yadav
@ 2017-07-20 17:51 ` Arvind Yadav
2017-07-20 17:51 ` [PATCH 03/28] video: fbdev: aty128fb: " Arvind Yadav
` (26 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-07-20 17:51 UTC (permalink / raw)
To: b.zolnierkie, paulus, benh, adaplas, mbroemme, FlorianSchandinat
Cc: linux-fbdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
17534 1824 48 19406 4bce video/fbdev/aty/atyfb_base.o
File size After adding 'const':
text data bss dec hex filename
18686 672 48 19406 4bce video/fbdev/aty/atyfb_base.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/aty/atyfb_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c
index 11026e7..d38cfc6 100644
--- a/drivers/video/fbdev/aty/atyfb_base.c
+++ b/drivers/video/fbdev/aty/atyfb_base.c
@@ -3762,7 +3762,7 @@ static void atyfb_pci_remove(struct pci_dev *pdev)
atyfb_remove(info);
}
-static struct pci_device_id atyfb_pci_tbl[] = {
+static const struct pci_device_id atyfb_pci_tbl[] = {
#ifdef CONFIG_FB_ATY_GX
{ PCI_DEVICE(PCI_VENDOR_ID_ATI, PCI_CHIP_MACH64GX) },
{ PCI_DEVICE(PCI_VENDOR_ID_ATI, PCI_CHIP_MACH64CX) },
--
2.7.4
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 03/28] video: fbdev: aty128fb: constify pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
2017-07-20 17:51 ` [PATCH 01/28] video: fbdev: radeon: constify pci_device_id Arvind Yadav
2017-07-20 17:51 ` [PATCH 02/28] video: fbdev: atyfb: " Arvind Yadav
@ 2017-07-20 17:51 ` Arvind Yadav
2017-07-20 17:51 ` [PATCH 04/28] video: fbdev: sunxvr2500: " Arvind Yadav
` (25 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-07-20 17:51 UTC (permalink / raw)
To: b.zolnierkie, paulus, benh, adaplas, mbroemme, FlorianSchandinat
Cc: linux-fbdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
11525 2048 8 13581 350d video/fbdev/aty/aty128fb.o
File size After adding 'const':
text data bss dec hex filename
13061 512 8 13581 350d video/fbdev/aty/aty128fb.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/aty/aty128fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/aty/aty128fb.c b/drivers/video/fbdev/aty/aty128fb.c
index fa07242..ba64e26 100644
--- a/drivers/video/fbdev/aty/aty128fb.c
+++ b/drivers/video/fbdev/aty/aty128fb.c
@@ -166,7 +166,7 @@ static int aty128_pci_resume(struct pci_dev *pdev);
static int aty128_do_resume(struct pci_dev *pdev);
/* supported Rage128 chipsets */
-static struct pci_device_id aty128_pci_tbl[] = {
+static const struct pci_device_id aty128_pci_tbl[] = {
{ PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_RAGE128_LE,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, rage_M3_pci },
{ PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_RAGE128_LF,
--
2.7.4
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 04/28] video: fbdev: sunxvr2500: constify pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
` (2 preceding siblings ...)
2017-07-20 17:51 ` [PATCH 03/28] video: fbdev: aty128fb: " Arvind Yadav
@ 2017-07-20 17:51 ` Arvind Yadav
2017-07-20 17:51 ` [PATCH 05/28] video: fbdev: asiliantfb: " Arvind Yadav
` (24 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-07-20 17:51 UTC (permalink / raw)
To: b.zolnierkie, paulus, benh, adaplas, mbroemme, FlorianSchandinat
Cc: linux-fbdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
390 552 0 942 3ae drivers/video/fbdev/sunxvr2500.o
File size After adding 'const':
text data bss dec hex filename
686 256 0 942 3ae drivers/video/fbdev/sunxvr2500.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/sunxvr2500.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/sunxvr2500.c b/drivers/video/fbdev/sunxvr2500.c
index 1a05329..544465b 100644
--- a/drivers/video/fbdev/sunxvr2500.c
+++ b/drivers/video/fbdev/sunxvr2500.c
@@ -220,7 +220,7 @@ static int s3d_pci_register(struct pci_dev *pdev,
return err;
}
-static struct pci_device_id s3d_pci_table[] = {
+static const struct pci_device_id s3d_pci_table[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_3DLABS, 0x002c), },
{ PCI_DEVICE(PCI_VENDOR_ID_3DLABS, 0x002d), },
{ PCI_DEVICE(PCI_VENDOR_ID_3DLABS, 0x002e), },
--
2.7.4
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 05/28] video: fbdev: asiliantfb: constify pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
` (3 preceding siblings ...)
2017-07-20 17:51 ` [PATCH 04/28] video: fbdev: sunxvr2500: " Arvind Yadav
@ 2017-07-20 17:51 ` Arvind Yadav
2017-07-20 17:51 ` [PATCH 06/28] video: fbdev: intelfb: " Arvind Yadav
` (23 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-07-20 17:51 UTC (permalink / raw)
To: b.zolnierkie, paulus, benh, adaplas, mbroemme, FlorianSchandinat
Cc: linux-fbdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
4703 512 0 5215 145f drivers/video/fbdev/asiliantfb.o
File size After adding 'const':
text data bss dec hex filename
4767 448 0 5215 145f drivers/video/fbdev/asiliantfb.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/asiliantfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/asiliantfb.c b/drivers/video/fbdev/asiliantfb.c
index 91eea45..ea31054 100644
--- a/drivers/video/fbdev/asiliantfb.c
+++ b/drivers/video/fbdev/asiliantfb.c
@@ -592,7 +592,7 @@ static void asiliantfb_remove(struct pci_dev *dp)
framebuffer_release(p);
}
-static struct pci_device_id asiliantfb_pci_tbl[] = {
+static const struct pci_device_id asiliantfb_pci_tbl[] = {
{ PCI_VENDOR_ID_CT, PCI_DEVICE_ID_CT_69000, PCI_ANY_ID, PCI_ANY_ID },
{ 0 }
};
--
2.7.4
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 06/28] video: fbdev: intelfb: constify pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
` (4 preceding siblings ...)
2017-07-20 17:51 ` [PATCH 05/28] video: fbdev: asiliantfb: " Arvind Yadav
@ 2017-07-20 17:51 ` Arvind Yadav
2017-07-20 17:51 ` [PATCH 07/28] video: fbdev: pvr2fb: " Arvind Yadav
` (22 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-07-20 17:51 UTC (permalink / raw)
To: b.zolnierkie, paulus, benh, adaplas, mbroemme, FlorianSchandinat
Cc: linux-fbdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
11749 896 24 12669 317d video/fbdev/intelfb/intelfbdrv.o
File size After adding 'const':
text data bss dec hex filename
12173 472 24 12669 317d video/fbdev/intelfb/intelfbdrv.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/intelfb/intelfbdrv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/intelfb/intelfbdrv.c b/drivers/video/fbdev/intelfb/intelfbdrv.c
index 6b444400..0127e81 100644
--- a/drivers/video/fbdev/intelfb/intelfbdrv.c
+++ b/drivers/video/fbdev/intelfb/intelfbdrv.c
@@ -173,7 +173,7 @@ static int intelfb_set_fbinfo(struct intelfb_info *dinfo);
#define INTELFB_CLASS_MASK 0
#endif
-static struct pci_device_id intelfb_pci_table[] = {
+static const struct pci_device_id intelfb_pci_table[] = {
{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_830M, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_DISPLAY_VGA << 8, INTELFB_CLASS_MASK, INTEL_830M },
{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_845G, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_DISPLAY_VGA << 8, INTELFB_CLASS_MASK, INTEL_845G },
{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_85XGM, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_DISPLAY_VGA << 8, INTELFB_CLASS_MASK, INTEL_85XGM },
--
2.7.4
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 07/28] video: fbdev: pvr2fb: constify pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
` (5 preceding siblings ...)
2017-07-20 17:51 ` [PATCH 06/28] video: fbdev: intelfb: " Arvind Yadav
@ 2017-07-20 17:51 ` Arvind Yadav
2017-07-20 17:51 ` [PATCH 08/28] video: fbdev: tridentfb: " Arvind Yadav
` (21 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-07-20 17:51 UTC (permalink / raw)
To: b.zolnierkie, paulus, benh, adaplas, mbroemme, FlorianSchandinat
Cc: linux-fbdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
5155 1312 40 6507 196b drivers/video/fbdev/pvr2fb.o
File size After adding 'const':
text data bss dec hex filename
5219 1248 40 6507 196b drivers/video/fbdev/pvr2fb.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/pvr2fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/pvr2fb.c b/drivers/video/fbdev/pvr2fb.c
index a2564ab..c6212ab 100644
--- a/drivers/video/fbdev/pvr2fb.c
+++ b/drivers/video/fbdev/pvr2fb.c
@@ -966,7 +966,7 @@ static void pvr2fb_pci_remove(struct pci_dev *pdev)
pci_release_regions(pdev);
}
-static struct pci_device_id pvr2fb_pci_tbl[] = {
+static const struct pci_device_id pvr2fb_pci_tbl[] = {
{ PCI_VENDOR_ID_NEC, PCI_DEVICE_ID_NEC_NEON250,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
{ 0, },
--
2.7.4
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 08/28] video: fbdev: tridentfb: constify pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
` (6 preceding siblings ...)
2017-07-20 17:51 ` [PATCH 07/28] video: fbdev: pvr2fb: " Arvind Yadav
@ 2017-07-20 17:51 ` Arvind Yadav
2017-07-20 17:51 ` [PATCH 09/28] video: fbdev: skeletonfb: " Arvind Yadav
` (20 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-07-20 17:51 UTC (permalink / raw)
To: b.zolnierkie, paulus, benh, adaplas, mbroemme, FlorianSchandinat
Cc: linux-fbdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
13206 1232 40 14478 388e video/fbdev/tridentfb.o
File size After adding 'const':
text data bss dec hex filename
13910 528 40 14478 388e video/fbdev/tridentfb.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/tridentfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/tridentfb.c b/drivers/video/fbdev/tridentfb.c
index 8a5bbc1..2847061 100644
--- a/drivers/video/fbdev/tridentfb.c
+++ b/drivers/video/fbdev/tridentfb.c
@@ -1737,7 +1737,7 @@ static void trident_pci_remove(struct pci_dev *dev)
}
/* List of boards that we are trying to support */
-static struct pci_device_id trident_devices[] = {
+static const struct pci_device_id trident_devices[] = {
{PCI_VENDOR_ID_TRIDENT, BLADE3D, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
{PCI_VENDOR_ID_TRIDENT, CYBERBLADEi7, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
{PCI_VENDOR_ID_TRIDENT, CYBERBLADEi7D, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
--
2.7.4
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 09/28] video: fbdev: skeletonfb: constify pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
` (7 preceding siblings ...)
2017-07-20 17:51 ` [PATCH 08/28] video: fbdev: tridentfb: " Arvind Yadav
@ 2017-07-20 17:51 ` Arvind Yadav
2017-07-20 17:51 ` [PATCH 10/28] video: fbdev: via: " Arvind Yadav
` (19 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-07-20 17:51 UTC (permalink / raw)
To: b.zolnierkie, paulus, benh, adaplas, mbroemme, FlorianSchandinat
Cc: linux-fbdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/skeletonfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/skeletonfb.c b/drivers/video/fbdev/skeletonfb.c
index e219a0a2..09a1d8c 100644
--- a/drivers/video/fbdev/skeletonfb.c
+++ b/drivers/video/fbdev/skeletonfb.c
@@ -866,7 +866,7 @@ static int xxxfb_resume(struct pci_dev *dev)
#define xxxfb_resume NULL
#endif /* CONFIG_PM */
-static struct pci_device_id xxxfb_id_table[] = {
+static const struct pci_device_id xxxfb_id_table[] = {
{ PCI_VENDOR_ID_XXX, PCI_DEVICE_ID_XXX,
PCI_ANY_ID, PCI_ANY_ID, PCI_BASE_CLASS_DISPLAY << 16,
PCI_CLASS_MASK, 0 },
--
2.7.4
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 10/28] video: fbdev: via: constify pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
` (8 preceding siblings ...)
2017-07-20 17:51 ` [PATCH 09/28] video: fbdev: skeletonfb: " Arvind Yadav
@ 2017-07-20 17:51 ` Arvind Yadav
2017-07-20 17:51 ` [PATCH 11/28] video: fbdev: savage: " Arvind Yadav
` (18 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-07-20 17:51 UTC (permalink / raw)
To: b.zolnierkie, paulus, benh, adaplas, mbroemme, FlorianSchandinat
Cc: linux-fbdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
3856 968 128 4952 1358 video/fbdev/via/via-core.o
File size After adding 'const':
text data bss dec hex filename
4304 520 128 4952 1358 video/fbdev/via/via-core.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/via/via-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/via/via-core.c b/drivers/video/fbdev/via/via-core.c
index 1d28e16..77774d8 100644
--- a/drivers/video/fbdev/via/via-core.c
+++ b/drivers/video/fbdev/via/via-core.c
@@ -724,7 +724,7 @@ static void via_pci_remove(struct pci_dev *pdev)
}
-static struct pci_device_id via_pci_table[] = {
+static const struct pci_device_id via_pci_table[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_VIA, UNICHROME_CLE266_DID),
.driver_data = UNICHROME_CLE266 },
{ PCI_DEVICE(PCI_VENDOR_ID_VIA, UNICHROME_K400_DID),
--
2.7.4
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 11/28] video: fbdev: savage: constify pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
` (9 preceding siblings ...)
2017-07-20 17:51 ` [PATCH 10/28] video: fbdev: via: " Arvind Yadav
@ 2017-07-20 17:51 ` Arvind Yadav
2017-07-20 17:51 ` [PATCH 12/28] video: fbdev: riva: " Arvind Yadav
` (17 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-07-20 17:51 UTC (permalink / raw)
To: b.zolnierkie, paulus, benh, adaplas, mbroemme, FlorianSchandinat
Cc: linux-fbdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
19916 1240 8 21164 52ac fbdev/savage/savagefb_driver.o
File size After adding 'const':
text data bss dec hex filename
20684 472 8 21164 52ac fbdev/savage/savagefb_driver.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/savage/savagefb_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/savage/savagefb_driver.c b/drivers/video/fbdev/savage/savagefb_driver.c
index c30a91c..c204683 100644
--- a/drivers/video/fbdev/savage/savagefb_driver.c
+++ b/drivers/video/fbdev/savage/savagefb_driver.c
@@ -2429,7 +2429,7 @@ static int savagefb_resume(struct pci_dev* dev)
}
-static struct pci_device_id savagefb_devices[] = {
+static const struct pci_device_id savagefb_devices[] = {
{PCI_VENDOR_ID_S3, PCI_CHIP_SUPSAV_MX128,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, FB_ACCEL_SUPERSAVAGE},
--
2.7.4
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 12/28] video: fbdev: riva: constify pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
` (10 preceding siblings ...)
2017-07-20 17:51 ` [PATCH 11/28] video: fbdev: savage: " Arvind Yadav
@ 2017-07-20 17:51 ` Arvind Yadav
2017-07-20 17:51 ` [PATCH 13/28] video: fbdev: i810: " Arvind Yadav
` (16 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-07-20 17:51 UTC (permalink / raw)
To: b.zolnierkie, paulus, benh, adaplas, mbroemme, FlorianSchandinat
Cc: linux-fbdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
13285 2080 3 15368 3c08 video/fbdev/riva/fbdev.o
File size After adding 'const':
text data bss dec hex filename
14677 688 3 15368 3c08 video/fbdev/riva/fbdev.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/riva/fbdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/riva/fbdev.c b/drivers/video/fbdev/riva/fbdev.c
index 2ef26ad..1ea78bb 100644
--- a/drivers/video/fbdev/riva/fbdev.c
+++ b/drivers/video/fbdev/riva/fbdev.c
@@ -101,7 +101,7 @@ static int rivafb_blank(int blank, struct fb_info *info);
*
* ------------------------------------------------------------------------- */
-static struct pci_device_id rivafb_pci_tbl[] = {
+static const struct pci_device_id rivafb_pci_tbl[] = {
{ PCI_VENDOR_ID_NVIDIA_SGS, PCI_DEVICE_ID_NVIDIA_SGS_RIVA128,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
{ PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_TNT,
--
2.7.4
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 13/28] video: fbdev: i810: constify pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
` (11 preceding siblings ...)
2017-07-20 17:51 ` [PATCH 12/28] video: fbdev: riva: " Arvind Yadav
@ 2017-07-20 17:51 ` Arvind Yadav
2017-07-20 17:51 ` [PATCH 14/28] video: fbdev: arkfb: " Arvind Yadav
` (15 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-07-20 17:51 UTC (permalink / raw)
To: b.zolnierkie, paulus, benh, adaplas, mbroemme, FlorianSchandinat
Cc: linux-fbdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
13132 520 56 13708 358c video/fbdev/i810/i810_main.o
File size After adding 'const':
text data bss dec hex filename
13356 296 56 13708 358c video/fbdev/i810/i810_main.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/i810/i810_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/i810/i810_main.c b/drivers/video/fbdev/i810/i810_main.c
index 2488baa..f0a758a 100644
--- a/drivers/video/fbdev/i810/i810_main.c
+++ b/drivers/video/fbdev/i810/i810_main.c
@@ -107,7 +107,7 @@ static const char * const i810_pci_list[] = {
"Intel(R) 815 (Internal Graphics with AGP) Framebuffer Device"
};
-static struct pci_device_id i810fb_pci_tbl[] = {
+static const struct pci_device_id i810fb_pci_tbl[] = {
{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82810_IG1,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82810_IG3,
--
2.7.4
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 14/28] video: fbdev: arkfb: constify pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
` (12 preceding siblings ...)
2017-07-20 17:51 ` [PATCH 13/28] video: fbdev: i810: " Arvind Yadav
@ 2017-07-20 17:51 ` Arvind Yadav
2017-07-20 17:51 ` [PATCH 15/28] video: fbdev: kyro: " Arvind Yadav
` (14 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-07-20 17:51 UTC (permalink / raw)
To: b.zolnierkie, paulus, benh, adaplas, mbroemme, FlorianSchandinat
Cc: linux-fbdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
12511 1920 0 14431 385f drivers/video/fbdev/arkfb.o
File size After adding 'const':
text data bss dec hex filename
12607 1824 0 14431 385f drivers/video/fbdev/arkfb.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/arkfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/arkfb.c b/drivers/video/fbdev/arkfb.c
index 6a317de..13ba371 100644
--- a/drivers/video/fbdev/arkfb.c
+++ b/drivers/video/fbdev/arkfb.c
@@ -1157,7 +1157,7 @@ static int ark_pci_resume (struct pci_dev* dev)
/* List of boards that we are trying to support */
-static struct pci_device_id ark_devices[] = {
+static const struct pci_device_id ark_devices[] = {
{PCI_DEVICE(0xEDD8, 0xA099)},
{0, 0, 0, 0, 0, 0, 0}
};
--
2.7.4
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 15/28] video: fbdev: kyro: constify pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
` (13 preceding siblings ...)
2017-07-20 17:51 ` [PATCH 14/28] video: fbdev: arkfb: " Arvind Yadav
@ 2017-07-20 17:51 ` Arvind Yadav
2017-07-20 17:51 ` [PATCH 16/28] video: fbdev: vermilion: " Arvind Yadav
` (13 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-07-20 17:51 UTC (permalink / raw)
To: b.zolnierkie, paulus, benh, adaplas, mbroemme, FlorianSchandinat
Cc: linux-fbdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
3190 2704 24 5918 171e video/fbdev/kyro/fbdev.o
File size After adding 'const':
text data bss dec hex filename
3290 2640 24 5918 171e video/fbdev/kyro/fbdev.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/kyro/fbdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/kyro/fbdev.c b/drivers/video/fbdev/kyro/fbdev.c
index f77478f..a7bd9f2 100644
--- a/drivers/video/fbdev/kyro/fbdev.c
+++ b/drivers/video/fbdev/kyro/fbdev.c
@@ -633,7 +633,7 @@ static int kyrofb_ioctl(struct fb_info *info,
return 0;
}
-static struct pci_device_id kyrofb_pci_tbl[] = {
+static const struct pci_device_id kyrofb_pci_tbl[] = {
{ PCI_VENDOR_ID_ST, PCI_DEVICE_ID_STG4000,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
{ 0, }
--
2.7.4
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 16/28] video: fbdev: vermilion: constify pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
` (14 preceding siblings ...)
2017-07-20 17:51 ` [PATCH 15/28] video: fbdev: kyro: " Arvind Yadav
@ 2017-07-20 17:51 ` Arvind Yadav
2017-07-20 17:51 ` [PATCH 17/28] video: fbdev: nvidia: " Arvind Yadav
` (12 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-07-20 17:51 UTC (permalink / raw)
To: b.zolnierkie, paulus, benh, adaplas, mbroemme, FlorianSchandinat
Cc: linux-fbdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
7953 568 96 8617 21a9 fbdev/vermilion/vermilion.o
File size After adding 'const':
text data bss dec hex filename
8017 504 96 8617 21a9 fbdev/vermilion/vermilion.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/vermilion/vermilion.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/vermilion/vermilion.c b/drivers/video/fbdev/vermilion/vermilion.c
index ce4c472..3fde493 100644
--- a/drivers/video/fbdev/vermilion/vermilion.c
+++ b/drivers/video/fbdev/vermilion/vermilion.c
@@ -1044,7 +1044,7 @@ static struct fb_ops vmlfb_ops = {
.fb_setcolreg = vmlfb_setcolreg
};
-static struct pci_device_id vml_ids[] = {
+static const struct pci_device_id vml_ids[] = {
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, VML_DEVICE_VDC)},
{0}
};
--
2.7.4
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 17/28] video: fbdev: nvidia: constify pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
` (15 preceding siblings ...)
2017-07-20 17:51 ` [PATCH 16/28] video: fbdev: vermilion: " Arvind Yadav
@ 2017-07-20 17:51 ` Arvind Yadav
2017-07-20 17:51 ` [PATCH 18/28] video: fbdev: mb862xx: " Arvind Yadav
` (11 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-07-20 17:51 UTC (permalink / raw)
To: b.zolnierkie, paulus, benh, adaplas, mbroemme, FlorianSchandinat
Cc: linux-fbdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
12149 768 36 12953 3299 video/fbdev/nvidia/nvidia.o
File size After adding 'const':
text data bss dec hex filename
12213 704 36 12953 3299 video/fbdev/nvidia/nvidia.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/nvidia/nvidia.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/nvidia/nvidia.c b/drivers/video/fbdev/nvidia/nvidia.c
index ce7dab7..418a2d0 100644
--- a/drivers/video/fbdev/nvidia/nvidia.c
+++ b/drivers/video/fbdev/nvidia/nvidia.c
@@ -55,7 +55,7 @@
/* HW cursor parameters */
#define MAX_CURS 32
-static struct pci_device_id nvidiafb_pci_tbl[] = {
+static const struct pci_device_id nvidiafb_pci_tbl[] = {
{PCI_VENDOR_ID_NVIDIA, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
PCI_BASE_CLASS_DISPLAY << 16, 0xff0000, 0},
{ 0, }
--
2.7.4
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 18/28] video: fbdev: mb862xx: constify pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
` (16 preceding siblings ...)
2017-07-20 17:51 ` [PATCH 17/28] video: fbdev: nvidia: " Arvind Yadav
@ 2017-07-20 17:51 ` Arvind Yadav
2017-07-20 17:51 ` [PATCH 19/28] video: fbdev: tdfx: " Arvind Yadav
` (10 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-07-20 17:51 UTC (permalink / raw)
To: b.zolnierkie, paulus, benh, adaplas, mbroemme, FlorianSchandinat
Cc: linux-fbdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
7326 1320 0 8646 21c6 fbdev/mb862xx/mb862xxfbdrv.o
File size After adding 'const':
text data bss dec hex filename
7454 1192 0 8646 21c6 fbdev/mb862xx/mb862xxfbdrv.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c b/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
index f9ec5c0..cd37252 100644
--- a/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
+++ b/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
@@ -982,7 +982,7 @@ static inline int mb862xx_pci_gdc_init(struct mb862xxfb_par *par)
#define CHIP_ID(id) \
{ PCI_DEVICE(PCI_VENDOR_ID_FUJITSU_LIMITED, id) }
-static struct pci_device_id mb862xx_pci_tbl[] = {
+static const struct pci_device_id mb862xx_pci_tbl[] = {
/* MB86295/MB86296 */
CHIP_ID(PCI_DEVICE_ID_FUJITSU_CORALP),
CHIP_ID(PCI_DEVICE_ID_FUJITSU_CORALPA),
--
2.7.4
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 19/28] video: fbdev: tdfx: constify pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
` (17 preceding siblings ...)
2017-07-20 17:51 ` [PATCH 18/28] video: fbdev: mb862xx: " Arvind Yadav
@ 2017-07-20 17:51 ` Arvind Yadav
2017-07-20 17:51 ` [PATCH 20/28] video: fbdev: sunxvr500: " Arvind Yadav
` (9 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-07-20 17:51 UTC (permalink / raw)
To: b.zolnierkie, paulus, benh, adaplas, mbroemme, FlorianSchandinat
Cc: linux-fbdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
8432 1456 16 9904 26b0 drivers/video/fbdev/tdfxfb.o
File size After adding 'const':
text data bss dec hex filename
8560 1328 16 9904 26b0 drivers/video/fbdev/tdfxfb.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/tdfxfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/tdfxfb.c b/drivers/video/fbdev/tdfxfb.c
index d5fa313..dec1fed 100644
--- a/drivers/video/fbdev/tdfxfb.c
+++ b/drivers/video/fbdev/tdfxfb.c
@@ -120,7 +120,7 @@ static const struct fb_var_screeninfo tdfx_var = {
static int tdfxfb_probe(struct pci_dev *pdev, const struct pci_device_id *id);
static void tdfxfb_remove(struct pci_dev *pdev);
-static struct pci_device_id tdfxfb_id_table[] = {
+static const struct pci_device_id tdfxfb_id_table[] = {
{ PCI_VENDOR_ID_3DFX, PCI_DEVICE_ID_3DFX_BANSHEE,
PCI_ANY_ID, PCI_ANY_ID, PCI_BASE_CLASS_DISPLAY << 16,
0xff0000, 0 },
--
2.7.4
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 20/28] video: fbdev: sunxvr500: constify pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
` (18 preceding siblings ...)
2017-07-20 17:51 ` [PATCH 19/28] video: fbdev: tdfx: " Arvind Yadav
@ 2017-07-20 17:51 ` Arvind Yadav
2017-07-20 17:51 ` [PATCH 21/28] video: fbdev: imsttfb: " Arvind Yadav
` (8 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-07-20 17:51 UTC (permalink / raw)
To: b.zolnierkie, paulus, benh, adaplas, mbroemme, FlorianSchandinat
Cc: linux-fbdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
170 488 0 658 292 drivers/video/fbdev/sunxvr500.o
File size After adding 'const':
text data bss dec hex filename
394 264 0 658 292 drivers/video/fbdev/sunxvr500.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/sunxvr500.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/sunxvr500.c b/drivers/video/fbdev/sunxvr500.c
index dc0d886..bc59593 100644
--- a/drivers/video/fbdev/sunxvr500.c
+++ b/drivers/video/fbdev/sunxvr500.c
@@ -393,7 +393,7 @@ static int e3d_pci_register(struct pci_dev *pdev,
return err;
}
-static struct pci_device_id e3d_pci_table[] = {
+static const struct pci_device_id e3d_pci_table[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_3DLABS, 0x7a0), },
{ PCI_DEVICE(0x1091, 0x7a0), },
{ PCI_DEVICE(PCI_VENDOR_ID_3DLABS, 0x7a2), },
--
2.7.4
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 21/28] video: fbdev: imsttfb: constify pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
` (19 preceding siblings ...)
2017-07-20 17:51 ` [PATCH 20/28] video: fbdev: sunxvr500: " Arvind Yadav
@ 2017-07-20 17:51 ` Arvind Yadav
2017-07-20 17:51 ` [PATCH 22/28] video: fbdev: pm2fb: " Arvind Yadav
` (7 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-07-20 17:51 UTC (permalink / raw)
To: b.zolnierkie, paulus, benh, adaplas, mbroemme, FlorianSchandinat
Cc: linux-fbdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
6736 856 0 7592 1da8 drivers/video/fbdev/imsttfb.o
File size After adding 'const':
text data bss dec hex filename
6832 760 0 7592 1da8 drivers/video/fbdev/imsttfb.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/imsttfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/imsttfb.c b/drivers/video/fbdev/imsttfb.c
index 4363c64..ecdcf35 100644
--- a/drivers/video/fbdev/imsttfb.c
+++ b/drivers/video/fbdev/imsttfb.c
@@ -1318,7 +1318,7 @@ imsttfb_ioctl(struct fb_info *info, u_int cmd, u_long arg)
}
}
-static struct pci_device_id imsttfb_pci_tbl[] = {
+static const struct pci_device_id imsttfb_pci_tbl[] = {
{ PCI_VENDOR_ID_IMS, PCI_DEVICE_ID_IMS_TT128,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, IBM },
{ PCI_VENDOR_ID_IMS, PCI_DEVICE_ID_IMS_TT3D,
--
2.7.4
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 22/28] video: fbdev: pm2fb: constify pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
` (20 preceding siblings ...)
2017-07-20 17:51 ` [PATCH 21/28] video: fbdev: imsttfb: " Arvind Yadav
@ 2017-07-20 17:51 ` Arvind Yadav
2017-07-20 17:51 ` [PATCH 23/28] video: fbdev: gxfb: " Arvind Yadav
` (6 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-07-20 17:51 UTC (permalink / raw)
To: b.zolnierkie, paulus, benh, adaplas, mbroemme, FlorianSchandinat
Cc: linux-fbdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
11940 660 16 12616 3148 drivers/video/fbdev/pm2fb.o
File size After adding 'const':
text data bss dec hex filename
12068 532 16 12616 3148 drivers/video/fbdev/pm2fb.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/pm2fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/pm2fb.c b/drivers/video/fbdev/pm2fb.c
index 1a4070f..bd6c2f5 100644
--- a/drivers/video/fbdev/pm2fb.c
+++ b/drivers/video/fbdev/pm2fb.c
@@ -1732,7 +1732,7 @@ static void pm2fb_remove(struct pci_dev *pdev)
framebuffer_release(info);
}
-static struct pci_device_id pm2fb_id_table[] = {
+static const struct pci_device_id pm2fb_id_table[] = {
{ PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_TVP4020,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
{ PCI_VENDOR_ID_3DLABS, PCI_DEVICE_ID_3DLABS_PERMEDIA2,
--
2.7.4
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 23/28] video: fbdev: gxfb: constify pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
` (21 preceding siblings ...)
2017-07-20 17:51 ` [PATCH 22/28] video: fbdev: pm2fb: " Arvind Yadav
@ 2017-07-20 17:51 ` Arvind Yadav
2017-07-20 17:51 ` [PATCH 24/28] video: fbdev: neofb: " Arvind Yadav
` (5 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-07-20 17:51 UTC (permalink / raw)
To: b.zolnierkie, paulus, benh, adaplas, mbroemme, FlorianSchandinat
Cc: linux-fbdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
2643 1616 16 4275 10b3 video/fbdev/geode/gxfb_core.o
File size After adding 'const':
text data bss dec hex filename
2707 1552 16 4275 10b3 video/fbdev/geode/gxfb_core.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/geode/gxfb_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/geode/gxfb_core.c b/drivers/video/fbdev/geode/gxfb_core.c
index ec9fc9a..f4f7637 100644
--- a/drivers/video/fbdev/geode/gxfb_core.c
+++ b/drivers/video/fbdev/geode/gxfb_core.c
@@ -474,7 +474,7 @@ static void gxfb_remove(struct pci_dev *pdev)
framebuffer_release(info);
}
-static struct pci_device_id gxfb_id_table[] = {
+static const struct pci_device_id gxfb_id_table[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_NS, PCI_DEVICE_ID_NS_GX_VIDEO) },
{ 0, }
};
--
2.7.4
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 24/28] video: fbdev: neofb: constify pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
` (22 preceding siblings ...)
2017-07-20 17:51 ` [PATCH 23/28] video: fbdev: gxfb: " Arvind Yadav
@ 2017-07-20 17:51 ` Arvind Yadav
2017-07-20 17:51 ` [PATCH 25/28] video: fbdev: s3fb: " Arvind Yadav
` (4 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-07-20 17:51 UTC (permalink / raw)
To: b.zolnierkie, paulus, benh, adaplas, mbroemme, FlorianSchandinat
Cc: linux-fbdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
12766 1064 21 13851 361b drivers/video/fbdev/neofb.o
File size After adding 'const':
text data bss dec hex filename
13086 744 21 13851 361b drivers/video/fbdev/neofb.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/neofb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/neofb.c b/drivers/video/fbdev/neofb.c
index db023a9..5d3a444 100644
--- a/drivers/video/fbdev/neofb.c
+++ b/drivers/video/fbdev/neofb.c
@@ -2138,7 +2138,7 @@ static void neofb_remove(struct pci_dev *dev)
}
}
-static struct pci_device_id neofb_devices[] = {
+static const struct pci_device_id neofb_devices[] = {
{PCI_VENDOR_ID_NEOMAGIC, PCI_CHIP_NM2070,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, FB_ACCEL_NEOMAGIC_NM2070},
--
2.7.4
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 25/28] video: fbdev: s3fb: constify pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
` (23 preceding siblings ...)
2017-07-20 17:51 ` [PATCH 24/28] video: fbdev: neofb: " Arvind Yadav
@ 2017-07-20 17:51 ` Arvind Yadav
2017-07-20 17:51 ` [PATCH 26/28] video: fbdev: pm3fb: " Arvind Yadav
` (3 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-07-20 17:51 UTC (permalink / raw)
To: b.zolnierkie, paulus, benh, adaplas, mbroemme, FlorianSchandinat
Cc: linux-fbdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
20994 2440 8 23442 5b92 drivers/video/fbdev/s3fb.o
File size After adding 'const':
text data bss dec hex filename
21506 1928 8 23442 5b92 drivers/video/fbdev/s3fb.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/s3fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/s3fb.c b/drivers/video/fbdev/s3fb.c
index 13b1090..d63f23e 100644
--- a/drivers/video/fbdev/s3fb.c
+++ b/drivers/video/fbdev/s3fb.c
@@ -1483,7 +1483,7 @@ static int s3_pci_resume(struct pci_dev* dev)
/* List of boards that we are trying to support */
-static struct pci_device_id s3_devices[] = {
+static const struct pci_device_id s3_devices[] = {
{PCI_DEVICE(PCI_VENDOR_ID_S3, 0x8810), .driver_data = CHIP_XXX_TRIO},
{PCI_DEVICE(PCI_VENDOR_ID_S3, 0x8811), .driver_data = CHIP_XXX_TRIO},
{PCI_DEVICE(PCI_VENDOR_ID_S3, 0x8812), .driver_data = CHIP_M65_AURORA64VP},
--
2.7.4
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 26/28] video: fbdev: pm3fb: constify pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
` (24 preceding siblings ...)
2017-07-20 17:51 ` [PATCH 25/28] video: fbdev: s3fb: " Arvind Yadav
@ 2017-07-20 17:51 ` Arvind Yadav
2017-07-20 17:51 ` [PATCH 27/28] video: fbdev: matroxfb: " Arvind Yadav
` (2 subsequent siblings)
28 siblings, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-07-20 17:51 UTC (permalink / raw)
To: b.zolnierkie, paulus, benh, adaplas, mbroemme, FlorianSchandinat
Cc: linux-fbdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
10332 596 16 10944 2ac0 drivers/video/fbdev/pm3fb.o
File size After adding 'const':
text data bss dec hex filename
10396 532 16 10944 2ac0 drivers/video/fbdev/pm3fb.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/pm3fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/pm3fb.c b/drivers/video/fbdev/pm3fb.c
index 6ff5077..6130aa5 100644
--- a/drivers/video/fbdev/pm3fb.c
+++ b/drivers/video/fbdev/pm3fb.c
@@ -1479,7 +1479,7 @@ static void pm3fb_remove(struct pci_dev *dev)
}
}
-static struct pci_device_id pm3fb_id_table[] = {
+static const struct pci_device_id pm3fb_id_table[] = {
{ PCI_VENDOR_ID_3DLABS, 0x0a,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
{ 0, }
--
2.7.4
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 27/28] video: fbdev: matroxfb: constify pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
` (25 preceding siblings ...)
2017-07-20 17:51 ` [PATCH 26/28] video: fbdev: pm3fb: " Arvind Yadav
@ 2017-07-20 17:51 ` Arvind Yadav
2017-07-20 17:51 ` [PATCH 28/28] video: fbdev: vt8623fb: " Arvind Yadav
2017-08-01 15:37 ` [PATCH 00/28] constify fbdev pci_device_id Bartlomiej Zolnierkiewicz
28 siblings, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-07-20 17:51 UTC (permalink / raw)
To: b.zolnierkie, paulus, benh, adaplas, mbroemme, FlorianSchandinat
Cc: linux-fbdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
19884 3036 96 23016 59e8 fbdev/matrox/matroxfb_base.o
File size After adding 'const':
text data bss dec hex filename
20300 2620 96 23016 59e8 fbdev/matrox/matroxfb_base.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/matrox/matroxfb_base.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/matrox/matroxfb_base.c b/drivers/video/fbdev/matrox/matroxfb_base.c
index 11eb094..a582907 100644
--- a/drivers/video/fbdev/matrox/matroxfb_base.c
+++ b/drivers/video/fbdev/matrox/matroxfb_base.c
@@ -1623,7 +1623,7 @@ static int initMatrox2(struct matrox_fb_info *minfo, struct board *b)
unsigned int memsize;
int err;
- static struct pci_device_id intel_82437[] = {
+ static const struct pci_device_id intel_82437[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82437) },
{ },
};
@@ -2116,7 +2116,7 @@ static void pci_remove_matrox(struct pci_dev* pdev) {
matroxfb_remove(minfo, 1);
}
-static struct pci_device_id matroxfb_devices[] = {
+static const struct pci_device_id matroxfb_devices[] = {
#ifdef CONFIG_FB_MATROX_MILLENIUM
{PCI_VENDOR_ID_MATROX, PCI_DEVICE_ID_MATROX_MIL,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
--
2.7.4
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH 28/28] video: fbdev: vt8623fb: constify pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
` (26 preceding siblings ...)
2017-07-20 17:51 ` [PATCH 27/28] video: fbdev: matroxfb: " Arvind Yadav
@ 2017-07-20 17:51 ` Arvind Yadav
2017-08-01 15:37 ` [PATCH 00/28] constify fbdev pci_device_id Bartlomiej Zolnierkiewicz
28 siblings, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-07-20 17:51 UTC (permalink / raw)
To: b.zolnierkie, paulus, benh, adaplas, mbroemme, FlorianSchandinat
Cc: linux-fbdev, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
11790 1913 0 13703 3587 drivers/video/fbdev/vt8623fb.o
File size After adding 'const':
text data bss dec hex filename
11854 1849 0 13703 3587 drivers/video/fbdev/vt8623fb.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/vt8623fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/vt8623fb.c b/drivers/video/fbdev/vt8623fb.c
index dd0f18e..9f34879 100644
--- a/drivers/video/fbdev/vt8623fb.c
+++ b/drivers/video/fbdev/vt8623fb.c
@@ -888,7 +888,7 @@ static int vt8623_pci_resume(struct pci_dev* dev)
/* List of boards that we are trying to support */
-static struct pci_device_id vt8623_devices[] = {
+static const struct pci_device_id vt8623_devices[] = {
{PCI_DEVICE(PCI_VENDOR_ID_VIA, 0x3122)},
{0, 0, 0, 0, 0, 0, 0}
};
--
2.7.4
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH 00/28] constify fbdev pci_device_id.
2017-07-20 17:51 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
` (27 preceding siblings ...)
2017-07-20 17:51 ` [PATCH 28/28] video: fbdev: vt8623fb: " Arvind Yadav
@ 2017-08-01 15:37 ` Bartlomiej Zolnierkiewicz
28 siblings, 0 replies; 30+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-08-01 15:37 UTC (permalink / raw)
To: Arvind Yadav
Cc: paulus, benh, adaplas, mbroemme, FlorianSchandinat, linux-fbdev,
linux-kernel
On Thursday, July 20, 2017 11:09:25 PM Arvind Yadav wrote:
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
Patches #1-28 queued for 4.14, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 30+ messages in thread