[PATCH 2/2] media: omapfb: relax compilation if COMPILE_TEST

[PATCH 2/2] media: omapfb: relax compilation if COMPILE_TEST

[Mauro Carvalho Chehab]

The dependency of DRM_OMAP = n can be relaxed for just
compilation test.

This allows building the omap3isp driver with allyesconfig
on ARM.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
---
 drivers/video/fbdev/omap2/omapfb/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/omap2/omapfb/Kconfig b/drivers/video/fbdev/omap2/omapfb/Kconfig
index e6226aeed17e..e42794a5e26c 100644
--- a/drivers/video/fbdev/omap2/omapfb/Kconfig
+++ b/drivers/video/fbdev/omap2/omapfb/Kconfig
@@ -4,7 +4,7 @@ config OMAP2_VRFB
 menuconfig FB_OMAP2
         tristate "OMAP2+ frame buffer support"
         depends on FB
-        depends on DRM_OMAP = n
+        depends on DRM_OMAP = n || COMPILE_TEST
 
         select FB_OMAP2_DSS
 	select OMAP2_VRFB if ARCH_OMAP2 || ARCH_OMAP3
-- 
2.14.3

Re: [PATCH 2/2] media: omapfb: relax compilation if COMPILE_TEST

[Laurent Pinchart]

Hi Mauro,

Thank you for the patch.

On Friday, 6 April 2018 18:33:20 EEST Mauro Carvalho Chehab wrote:
> The dependency of DRM_OMAP = n can be relaxed for just
> compilation test.
> 
> This allows building the omap3isp driver with allyesconfig
> on ARM.

omapfb has nothing to do with omap3isp. I assume you meant omap_vout.

There's a reason why both DRM_OMAP and FB_OMAP2 can't be compiled at the same 
time, they export identical symbols. I believe you will end up with link 
failures if you do so.

> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
> ---
>  drivers/video/fbdev/omap2/omapfb/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/omap2/omapfb/Kconfig
> b/drivers/video/fbdev/omap2/omapfb/Kconfig index e6226aeed17e..e42794a5e26c
> 100644
> --- a/drivers/video/fbdev/omap2/omapfb/Kconfig
> +++ b/drivers/video/fbdev/omap2/omapfb/Kconfig
> @@ -4,7 +4,7 @@ config OMAP2_VRFB
>  menuconfig FB_OMAP2
>          tristate "OMAP2+ frame buffer support"
>          depends on FB
> -        depends on DRM_OMAP = n
> +        depends on DRM_OMAP = n || COMPILE_TEST
> 
>          select FB_OMAP2_DSS
>  	select OMAP2_VRFB if ARCH_OMAP2 || ARCH_OMAP3

-- 
Regards,

Laurent Pinchart

Re: [PATCH 2/2] media: omapfb: relax compilation if COMPILE_TEST

[Mauro Carvalho Chehab]

Em Sat, 07 Apr 2018 14:46:56 +0300
Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu:

> Hi Mauro,
> 
> Thank you for the patch.
> 
> On Friday, 6 April 2018 18:33:20 EEST Mauro Carvalho Chehab wrote:
> > The dependency of DRM_OMAP = n can be relaxed for just
> > compilation test.
> > 
> > This allows building the omap3isp driver with allyesconfig
> > on ARM.  
> 
> omapfb has nothing to do with omap3isp. I assume you meant omap_vout.
> 
> There's a reason why both DRM_OMAP and FB_OMAP2 can't be compiled at the same 
> time, they export identical symbols. I believe you will end up with link 
> failures if you do so.

Ah, OK. I'll just drop this patch.

Thanks,
Mauro