Re: [PATCH v4 3/3] fbcon: Add option to enable legacy hardware acceleration

[Helge Deller <deller@gmx.de>]

Hi Geert,

On 2/4/22 11:24, Geert Uytterhoeven wrote:
> On Fri, Feb 4, 2022 at 11:17 AM Helge Deller <deller@gmx.de> wrote:
>> On 2/4/22 09:37, Geert Uytterhoeven wrote:
>>> On Wed, Feb 2, 2022 at 8:05 PM Helge Deller <deller@gmx.de> wrote:
>>>> Add a config option CONFIG_FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION to
>>>> enable bitblt and fillrect hardware acceleration in the framebuffer
>>>> console. If disabled, such acceleration will not be used, even if it is
>>>> supported by the graphics hardware driver.
>>>
>>> Note that this also applies to vertical panning and wrapping.
>>
>> That's correct.
>> Would you mind to send a patch which adds this info?
>
> To add it where? "bitblt and fillrect" are only mentioned in the patch
> description.
>
> The Kconfig help entry just talks about "hardware acceleration",
> which can mean any trick supported by the hardware.

Yes, I thought about extending the Kconfig help entry text to
mention vertical panning and wrapping as well.
If you have an idea how that should be phrased, I think it
makes sense to add it.

Helge