* [PATCH 8/14] drivers/video/sunxvr2500.c: fix error return code [not found] <1345365870-29831-1-git-send-email-Julia.Lawall@lip6.fr> @ 2012-08-19 8:44 ` Julia Lawall 2012-08-23 20:48 ` Florian Tobias Schandinat 0 siblings, 1 reply; 2+ messages in thread From: Julia Lawall @ 2012-08-19 8:44 UTC (permalink / raw) To: Florian Tobias Schandinat; +Cc: kernel-janitors, linux-fbdev, linux-kernel From: Julia Lawall <Julia.Lawall@lip6.fr> Initialize return variable before exiting on an error path. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- drivers/video/sunxvr2500.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/video/sunxvr2500.c b/drivers/video/sunxvr2500.c index 5848436..7fbcba8 100644 --- a/drivers/video/sunxvr2500.c +++ b/drivers/video/sunxvr2500.c @@ -181,8 +181,10 @@ static int __devinit s3d_pci_register(struct pci_dev *pdev, sp->fb_size = info->fix.line_length * sp->height; sp->fb_base = ioremap(sp->fb_base_phys, sp->fb_size); - if (!sp->fb_base) + if (!sp->fb_base) { + err = -ENOMEM; goto err_release_pci; + } err = s3d_set_fbinfo(sp); if (err) ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 8/14] drivers/video/sunxvr2500.c: fix error return code 2012-08-19 8:44 ` [PATCH 8/14] drivers/video/sunxvr2500.c: fix error return code Julia Lawall @ 2012-08-23 20:48 ` Florian Tobias Schandinat 0 siblings, 0 replies; 2+ messages in thread From: Florian Tobias Schandinat @ 2012-08-23 20:48 UTC (permalink / raw) To: Julia Lawall; +Cc: kernel-janitors, linux-fbdev, linux-kernel On 08/19/2012 08:44 AM, Julia Lawall wrote: > From: Julia Lawall <Julia.Lawall@lip6.fr> > > Initialize return variable before exiting on an error path. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // <smpl> > ( > if@p1 (\(ret < 0\|ret != 0\)) > { ... return ret; } > | > ret@p1 = 0 > ) > ... when != ret = e1 > when != &ret > *if(...) > { > ... when != ret = e2 > when forall > return ret; > } > > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Applied. Thanks, Florian Tobias Schandinat > > --- > drivers/video/sunxvr2500.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/video/sunxvr2500.c b/drivers/video/sunxvr2500.c > index 5848436..7fbcba8 100644 > --- a/drivers/video/sunxvr2500.c > +++ b/drivers/video/sunxvr2500.c > @@ -181,8 +181,10 @@ static int __devinit s3d_pci_register(struct pci_dev *pdev, > sp->fb_size = info->fix.line_length * sp->height; > > sp->fb_base = ioremap(sp->fb_base_phys, sp->fb_size); > - if (!sp->fb_base) > + if (!sp->fb_base) { > + err = -ENOMEM; > goto err_release_pci; > + } > > err = s3d_set_fbinfo(sp); > if (err) > > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-23 20:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1345365870-29831-1-git-send-email-Julia.Lawall@lip6.fr>
2012-08-19 8:44 ` [PATCH 8/14] drivers/video/sunxvr2500.c: fix error return code Julia Lawall
2012-08-23 20:48 ` Florian Tobias Schandinat
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox