[PATCH v4] video: fbdev: via: refactor strcpy and viafb_name

[PATCH v4] video: fbdev: via: refactor strcpy and viafb_name

[Ajith P V]

Eliminate the single-use file-scope variable `viafb_name` and pass the
"Via" string literal directly to strcpy().

Since "Via" is a literal constant, the compiler safely executes
compile-time bounds checking during fortify verification. This satisfies
the security initiative requirements while minimizing code complexity.

Signed-off-by: Ajith P V <ajithpv.linux@gmail.com>
---
v4:
  - Drop the variable entirely and use the literal string directly in
    strcpy() as suggested by Helge Deller.
v3:
  - Restore the original "Via" string value to prevent userspace ABI
    regressions, while keeping the 'static const char[]' optimization as
    suggested by Sashiko AI.
v2:
  - Keep variable static but change it to a const array
    'static const char viafb_name[] = "viafb"' as suggested by Helge Deller
    to let the compiler leverage compile-time checks.

 drivers/video/fbdev/via/viafbdev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/via/viafbdev.c b/drivers/video/fbdev/via/viafbdev.c
index 80f95dac32c8..dd9374e8ad09 100644
--- a/drivers/video/fbdev/via/viafbdev.c
+++ b/drivers/video/fbdev/via/viafbdev.c
@@ -16,7 +16,6 @@
 #define _MASTER_FILE
 #include "global.h"
 
-static char *viafb_name = "Via";
 static u32 pseudo_pal[17];
 
 /* video mode */
@@ -144,7 +143,7 @@ static void viafb_setup_fixinfo(struct fb_fix_screeninfo *fix,
 	struct viafb_par *viaparinfo)
 {
 	memset(fix, 0, sizeof(struct fb_fix_screeninfo));
-	strcpy(fix->id, viafb_name);
+	strcpy(fix->id, "Via");
 
 	fix->smem_start = viaparinfo->fbmem;
 	fix->smem_len = viaparinfo->fbmem_free;
-- 
2.43.0

Re: [PATCH v4] video: fbdev: via: refactor strcpy and viafb_name

[Helge Deller]

On 8/18/26 13:17, Ajith P V wrote:
> Eliminate the single-use file-scope variable `viafb_name` and pass the
> "Via" string literal directly to strcpy().
> 
> Since "Via" is a literal constant, the compiler safely executes
> compile-time bounds checking during fortify verification. This satisfies
> the security initiative requirements while minimizing code complexity.
> 
> Signed-off-by: Ajith P V <ajithpv.linux@gmail.com>
> ...
>   drivers/video/fbdev/via/viafbdev.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
applied.

Thanks!
Helge