From: Markus Elfring <Markus.Elfring@web.de>
To: "Helge Deller" <deller@gmx.de>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
"Kees Cook" <kees@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
kernel-janitors@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: fbdev: arkfb: Move a variable assignment behind a condition check in ics5342_init()
Date: Sat, 18 Jul 2026 22:34:33 +0200 [thread overview]
Message-ID: <550584cc-863d-48c3-813b-3a0cb45d9084@web.de> (raw)
In-Reply-To: <40d5e392-3f99-44c9-b30a-3481f60143ba@gmx.de>
>> The address of a data structure member was determined before
>> a corresponding null pointer check in the implementation of
>> the function “ics5342_init”.
>>
>> Thus avoid the risk for undefined behaviour by moving the assignment
>> for the variable “info” behind a condition check.
>>
>> This issue was detected by using the Coccinelle software.
>
> There is no "risk" here.
> It just adds an offset to a potential NULL value (which isn't then used afterwards).
Does your understanding of programming language details differ from the view of
SEI CERT C Coding Standard (from the Carnegie Mellon University)?
https://cmu-sei.github.io/secure-coding-standards/sei-cert-c-coding-standard/rules/expressions-exp/exp34-c/
Regards,
Markus
next prev parent reply other threads:[~2026-07-18 20:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 10:18 [PATCH] fbdev: arkfb: Move a variable assignment behind a condition check in ics5342_init() Markus Elfring
2026-07-18 18:17 ` Helge Deller
2026-07-18 20:34 ` Markus Elfring [this message]
2026-07-18 20:59 ` Helge Deller
2026-07-19 6:50 ` Markus Elfring
2026-07-18 21:47 ` Uwe Kleine-König
2026-07-19 7:24 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550584cc-863d-48c3-813b-3a0cb45d9084@web.de \
--to=markus.elfring@web.de \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=kees@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox