* [PATCH 2/8] staging: sm750fb: change sii164ResetChip to snake_case
@ 2025-04-05 10:21 Richard Akintola
0 siblings, 0 replies; 2+ messages in thread
From: Richard Akintola @ 2025-04-05 10:21 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, linux-staging,
linux-kernel, outreachy
Cc: julia.lawall, princerichard17a
Change camelCase function name sii164ResetChip to sii164_reset_chip
to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164ResetChip>
Signed-off-by: Richard Akintola <princerichard17a@gmail.com>
---
drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
drivers/staging/sm750fb/ddk750_sii164.c | 4 ++--
drivers/staging/sm750fb/ddk750_sii164.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
index 3fb14eff2de1..6dee95e60a6e 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.c
+++ b/drivers/staging/sm750fb/ddk750_dvi.c
@@ -18,7 +18,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {
.get_vendor_id = sii164_get_vendor_id,
.get_device_id = sii164_get_device_id,
#ifdef SII164_FULL_FUNCTIONS
- .reset_chip = sii164ResetChip,
+ .reset_chip = sii164_reset_chip,
.get_chip_string = sii164GetChipString,
.set_power = sii164SetPower,
.enable_hot_plug_detection = sii164EnableHotPlugDetection,
diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
index 223c181dc649..284c32f7e9b4 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.c
+++ b/drivers/staging/sm750fb/ddk750_sii164.c
@@ -250,10 +250,10 @@ long sii164_init_chip(unsigned char edge_select,
#ifdef SII164_FULL_FUNCTIONS
/*
- * sii164ResetChip
+ * sii164_reset_chip
* This function resets the DVI Controller Chip.
*/
-void sii164ResetChip(void)
+void sii164_reset_chip(void)
{
/* Power down */
sii164SetPower(0);
diff --git a/drivers/staging/sm750fb/ddk750_sii164.h b/drivers/staging/sm750fb/ddk750_sii164.h
index a76091f6622b..7a71f94a1e9b 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.h
+++ b/drivers/staging/sm750fb/ddk750_sii164.h
@@ -31,7 +31,7 @@ unsigned short sii164_get_vendor_id(void);
unsigned short sii164_get_device_id(void);
#ifdef SII164_FULL_FUNCTIONS
-void sii164ResetChip(void);
+void sii164_reset_chip(void);
char *sii164GetChipString(void);
void sii164SetPower(unsigned char powerUp);
void sii164EnableHotPlugDetection(unsigned char enableHotPlug);
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH 0/8] staging: sm750fb: change function naming style
@ 2025-04-05 13:00 Richard Akintola
2025-04-05 13:00 ` [PATCH 2/8] staging: sm750fb: change sii164ResetChip to snake_case Richard Akintola
0 siblings, 1 reply; 2+ messages in thread
From: Richard Akintola @ 2025-04-05 13:00 UTC (permalink / raw)
To: outreachy
Cc: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, linux-staging,
linux-kernel, Richard Akintola
Address checkpatch's "Avoid camelCase" for sm750fb module by changing
function name to conform to kernel code style.
The patches are required to be applied in sequence.
Richard Akintola (8):
staging: sm750fb: change sii164GetDeviceID to snake_case
staging: sm750fb: change sii164ResetChip to snake_case
staging: sm750fb: change sii164SetPower to snake_case
staging: sm750fb: change sii164GetChipString to snake_case
staging: sm750fb: change sii164EnableHotPlugDetection to snake_case
staging: sm750fb: change sii164IsConnected to snake_case
staging: sm750fb: change sii164CheckInterrupt to snake_case
staging: sm750fb: change sii164ClearInterrupt to snake_case
drivers/staging/sm750fb/ddk750_dvi.c | 16 +++++-----
drivers/staging/sm750fb/ddk750_sii164.c | 42 ++++++++++++-------------
drivers/staging/sm750fb/ddk750_sii164.h | 16 +++++-----
3 files changed, 37 insertions(+), 37 deletions(-)
--
2.39.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 2/8] staging: sm750fb: change sii164ResetChip to snake_case
2025-04-05 13:00 [PATCH 0/8] staging: sm750fb: change function naming style Richard Akintola
@ 2025-04-05 13:00 ` Richard Akintola
0 siblings, 0 replies; 2+ messages in thread
From: Richard Akintola @ 2025-04-05 13:00 UTC (permalink / raw)
To: outreachy
Cc: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, linux-staging,
linux-kernel, Richard Akintola
Change camelCase function name sii164ResetChip to sii164_reset_chip
to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164ResetChip>
Signed-off-by: Richard Akintola <princerichard17a@gmail.com>
---
drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
drivers/staging/sm750fb/ddk750_sii164.c | 4 ++--
drivers/staging/sm750fb/ddk750_sii164.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
index 3fb14eff2de1..6dee95e60a6e 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.c
+++ b/drivers/staging/sm750fb/ddk750_dvi.c
@@ -18,7 +18,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {
.get_vendor_id = sii164_get_vendor_id,
.get_device_id = sii164_get_device_id,
#ifdef SII164_FULL_FUNCTIONS
- .reset_chip = sii164ResetChip,
+ .reset_chip = sii164_reset_chip,
.get_chip_string = sii164GetChipString,
.set_power = sii164SetPower,
.enable_hot_plug_detection = sii164EnableHotPlugDetection,
diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
index 223c181dc649..284c32f7e9b4 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.c
+++ b/drivers/staging/sm750fb/ddk750_sii164.c
@@ -250,10 +250,10 @@ long sii164_init_chip(unsigned char edge_select,
#ifdef SII164_FULL_FUNCTIONS
/*
- * sii164ResetChip
+ * sii164_reset_chip
* This function resets the DVI Controller Chip.
*/
-void sii164ResetChip(void)
+void sii164_reset_chip(void)
{
/* Power down */
sii164SetPower(0);
diff --git a/drivers/staging/sm750fb/ddk750_sii164.h b/drivers/staging/sm750fb/ddk750_sii164.h
index a76091f6622b..7a71f94a1e9b 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.h
+++ b/drivers/staging/sm750fb/ddk750_sii164.h
@@ -31,7 +31,7 @@ unsigned short sii164_get_vendor_id(void);
unsigned short sii164_get_device_id(void);
#ifdef SII164_FULL_FUNCTIONS
-void sii164ResetChip(void);
+void sii164_reset_chip(void);
char *sii164GetChipString(void);
void sii164SetPower(unsigned char powerUp);
void sii164EnableHotPlugDetection(unsigned char enableHotPlug);
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-05 13:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-05 10:21 [PATCH 2/8] staging: sm750fb: change sii164ResetChip to snake_case Richard Akintola
-- strict thread matches above, loose matches on Subject: below --
2025-04-05 13:00 [PATCH 0/8] staging: sm750fb: change function naming style Richard Akintola
2025-04-05 13:00 ` [PATCH 2/8] staging: sm750fb: change sii164ResetChip to snake_case Richard Akintola
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox