Re: [PATCH 3/3] mdacon: rework dependency list

[Thomas Zimmermann <tzimmermann@suse.de>]

Am 25.02.25 um 17:44 schrieb Arnd Bergmann:
> From: Arnd Bergmann <arnd@arndb.de>
>
> mdacon has roughly the same dependencies as vgacon but expresses them
> as a negative list instead of a positive list, with the only practical
> difference being PowerPC/CHRP, which uses vga16fb instead of vgacon.
>
> The CONFIG_MDA_CONSOLE description advises to only turn it on when vgacon
> is also used because MDA/Hercules-only systems should be using vgacon
> instead, so just change the list to enforce that directly for simplicity.
>
> The probing was broken from 2002 to 2008, this improves on the fix
> that was added then: If vgacon is a loadable module, then mdacon
> cannot be built-in now, and the list of systems that support vgacon
> is carried over.
>
> Fixes: 0b9cf3aa6b1e ("mdacon messing up default vc's - set default to vc13-16 again")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
> I have no idea when the last time was that someone actually tried using
> dualhead vgacon/mdacon with two ISA cards, or if it still works. We may
> be better off removing the driver altogether, but I don't see anything
> immediately wrong it with it.
> ---
>   drivers/video/console/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig
> index ea4863919eb9..12f54480f57f 100644
> --- a/drivers/video/console/Kconfig
> +++ b/drivers/video/console/Kconfig
> @@ -24,7 +24,7 @@ config VGA_CONSOLE
>   	  Say Y.
>   
>   config MDA_CONSOLE
> -	depends on !M68K && !PARISC && ISA
> +	depends on VGA_CONSOLE && ISA
>   	tristate "MDA text console (dual-headed)"
>   	help
>   	  Say Y here if you have an old MDA or monochrome Hercules graphics

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)