Re: [PATCH 06/17] platinumfb: Fix resource management

[Geert Uytterhoeven <geert@linux-m68k.org>]

On Sat, 29 Sep 2007, Antonino A. Daplas wrote:
> From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> 
> Current kernels have a non-working platinumfb due to some resource
> management issues. This fixes it.
> 
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Antonino Daplas <adaplas@gmail.com>
> ---
> 
>  drivers/video/platinumfb.c |   48 ++++++++++++++++++++++++--------------------
>  1 files changed, 26 insertions(+), 22 deletions(-)
> 
> diff --git a/drivers/video/platinumfb.c b/drivers/video/platinumfb.c
> index 8503e73..cbe71a5 100644
> --- a/drivers/video/platinumfb.c
> +++ b/drivers/video/platinumfb.c
> @@ -17,6 +17,8 @@
>   *  more details.
>   */
>  
> +#undef DEBUG
> +
>  #include <linux/module.h>
>  #include <linux/kernel.h>
>  #include <linux/errno.h>

Probably scripts/checkpatch.pl should be taught to complain about
`#undef DEBUG'.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/