From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>,
Andy Whitcroft <apw@uk.ibm.com>
Subject: Re: [PATCH 06/17] platinumfb: Fix resource management
Date: Sun, 30 Sep 2007 09:11:37 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0709300910570.10965@anakin> (raw)
In-Reply-To: <1191102785.28637.2.camel@pasglop>
On Sun, 30 Sep 2007, Benjamin Herrenschmidt wrote:
> > Probably scripts/checkpatch.pl should be taught to complain about
> > `#undef DEBUG'.
>
> Why ? Whenever I have things that are #ifdef DEBUG in the file (such as
> dev_dbg statements), I always leave a #undef DEBUG statement at the top.
Because it overrides a -DDEBUG on the build command line.
> That way, I know I can enable debug in that file by flicking it.
Just add #define DEBUG at the top?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2007-09-30 7:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-29 1:29 [PATCH 06/17] platinumfb: Fix resource management Antonino A. Daplas
2007-09-29 9:16 ` Geert Uytterhoeven
2007-09-29 21:53 ` Benjamin Herrenschmidt
2007-09-30 7:11 ` Geert Uytterhoeven [this message]
2007-09-30 8:03 ` Benjamin Herrenschmidt
2007-10-03 20:56 ` Andrew Morton
2007-10-03 21:29 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0709300910570.10965@anakin \
--to=geert@linux-m68k.org \
--cc=akpm@osdl.org \
--cc=apw@uk.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox