From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] staging: fbtft: Consider type of init sequence values in fbtft_init_display()
Date: Wed, 16 Mar 2022 18:51:20 +0200 [thread overview]
Message-ID: <YjIViC4U3ZwfiXlU@smile.fi.intel.com> (raw)
In-Reply-To: <Yi97SaQdudVfKV9W@kroah.com>
On Mon, Mar 14, 2022 at 06:28:41PM +0100, Greg Kroah-Hartman wrote:
> On Fri, Mar 04, 2022 at 09:34:14PM +0200, Andy Shevchenko wrote:
...
> Any reason you didn't test build this?
My test build doesn't include the WERROR for this driver, so I missed the
warning. Sorry for that. Now fixed.
> drivers/staging/fbtft/fbtft-core.c: In function ‘fbtft_init_display’:
> drivers/staging/fbtft/fbtft-core.c:1038:48: error: passing argument 3 of ‘fbtft_dbg_hex’ discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
> 1038 | s16, &par->init_sequence[i + 1], j,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/staging/fbtft/fbtft.h:441:50: note: in definition of macro ‘fbtft_par_dbg_hex’
> 441 | fbtft_dbg_hex(dev, sizeof(type), buf,\
> | ^~~
> drivers/staging/fbtft/fbtft-core.c:52:26: note: expected ‘void *’ but argument is of type ‘const s16 *’ {aka ‘const short int *’}
> 52 | void *buf, size_t len, const char *fmt, ...)
> | ~~~~~~^~~
> LD [M] drivers/staging/gdm724x/gdmulte.o
> cc1: all warnings being treated as errors
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-03-16 16:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 19:34 [PATCH v1 1/1] staging: fbtft: Consider type of init sequence values in fbtft_init_display() Andy Shevchenko
2022-03-08 10:18 ` Andy Shevchenko
2022-03-08 10:46 ` Greg Kroah-Hartman
2022-03-08 12:13 ` Andy Shevchenko
2022-03-14 17:28 ` Greg Kroah-Hartman
2022-03-16 16:51 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjIViC4U3ZwfiXlU@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox