[PATCH] fbcon: Remove obsolete reference to initmem_freed

[PATCH] fbcon: Remove obsolete reference to initmem_freed

[Geert Uytterhoeven]

initmem_freed was removed in v2.1.124, and the underlying issue was
fixed for good in commit 92b004d1aa9f367c ("video/logo: prevent use of
logos after they have been freed").

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/video/fbdev/core/fbcon.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
index 594650452afd14d8..1be8aa9f80747987 100644
--- a/drivers/video/fbdev/core/fbcon.c
+++ b/drivers/video/fbdev/core/fbcon.c
@@ -2180,7 +2180,6 @@ static int fbcon_switch(struct vc_data *vc)
 	if (logo_shown == FBCON_LOGO_DRAW) {
 
 		logo_shown = fg_console;
-		/* This is protected above by initmem_freed */
 		fb_show_logo(info, ops->rotate);
 		update_region(vc,
 			      vc->vc_origin + vc->vc_size_row * vc->vc_top,
-- 
2.25.1

Re: [PATCH] fbcon: Remove obsolete reference to initmem_freed

[Daniel Vetter]

On Wed, Jun 08, 2022 at 05:41:16PM +0200, Geert Uytterhoeven wrote:
> initmem_freed was removed in v2.1.124, and the underlying issue was
> fixed for good in commit 92b004d1aa9f367c ("video/logo: prevent use of
> logos after they have been freed").
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

So I got totally lost in late_initcall_sync trying to figure out whether
there's any fun races against driver load, and I guess as long as you
don't manage to hotplug an usb display link at just the right time this
works.

But also that's all just the existing logo.c code, so pure distraction.

Thanks for your patch, pushed to drm-misc-next.
-Daniel

> ---
>  drivers/video/fbdev/core/fbcon.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
> index 594650452afd14d8..1be8aa9f80747987 100644
> --- a/drivers/video/fbdev/core/fbcon.c
> +++ b/drivers/video/fbdev/core/fbcon.c
> @@ -2180,7 +2180,6 @@ static int fbcon_switch(struct vc_data *vc)
>  	if (logo_shown == FBCON_LOGO_DRAW) {
>  
>  		logo_shown = fg_console;
> -		/* This is protected above by initmem_freed */
>  		fb_show_logo(info, ops->rotate);
>  		update_region(vc,
>  			      vc->vc_origin + vc->vc_size_row * vc->vc_top,
> -- 
> 2.25.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch